Pull request for UEFI sub-system for efi-2021-04-rc1

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Pull request for UEFI sub-system for efi-2021-04-rc1

Heinrich Schuchardt
Dear Tom,

The following changes since commit ee6726be4f0dccb612f0193c62ca149164c8a5af:

   Merge tag 'ti-v2021.04-rc1' of
https://gitlab.denx.de/u-boot/custodians/u-boot-ti (2021-01-12 09:32:48
-0500)

are available in the Git repository at:

   https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git
tags/efi-2021-04-rc1

for you to fetch changes up to 8e70f1cb3f2c18d574b087d4fc1d79e68ce98fa9:

   efi_selftest: dtbdump support EFI_DT_FIXUP_PROTOCOL (2021-01-13
02:38:01 +0100)

Gitlab showed no problems:
https://gitlab.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/5854

----------------------------------------------------------------
Pull request for UEFI sub-system for efi-2021-04-rc1

In the UEFI sub-system:

* implement non-blocking file services
* print boot device and file path in helloworld.efi
* improve detection of boot device
* correct argument handling in efivar.py
* implement EFI_DT_FIXUP_PROTOCOL

Bug fixes:

* adjust conitrace command for low baud rates
* check that FIT images are valid FDTs

----------------------------------------------------------------
Heinrich Schuchardt (16):
       efi_loader: implement non-blocking file services
       tools: efivar.py without arguments
       tools: efivar.py: incorrect indentation
       tools: efivar.py should check GUID when deleting
       tools: efivar.py unused variable
       efi_loader: simplify running helloworld.efi
       efi_loader: print boot device and file path in helloworld
       efi_loader: carve out efi_check_pe()
       image-fit: fit_check_format check for valid FDT
       efi_loader: setting boot device
       efi_loader: move efi_(u)intn_t to efi.h
       efi_loader: typedef efi_string_t text output protocol
       efi_loader: remove outdated TODO in efi_memory.c
       cmd: conitrace: increase wait for next key
       efi_loader: implement EFI_DT_FIXUP_PROTOCOL
       efi_selftest: dtbdump support EFI_DT_FIXUP_PROTOCOL

  cmd/bootefi.c                     | 234 +++++++++++-----------------
  cmd/conitrace.c                   |   4 +-
  cmd/efidebug.c                    |   5 +
  common/image-fit.c                |   6 +
  doc/uefi/uefi.rst                 |  11 +-
  fs/fs.c                           |   3 +-
  include/efi.h                     |   5 +
  include/efi_api.h                 |  34 ++--
  include/efi_dt_fixup.h            |  39 +++++
  include/efi_loader.h              |  10 +-
  lib/efi_loader/Makefile           |   3 +
  lib/efi_loader/efi_console.c      |   6 +-
  lib/efi_loader/efi_dt_fixup.c     | 160 +++++++++++++++++++
  lib/efi_loader/efi_file.c         | 317
++++++++++++++++++++++++++++++++------
  lib/efi_loader/efi_image_loader.c |  80 ++++++----
  lib/efi_loader/efi_memory.c       |   2 -
  lib/efi_loader/efi_root_node.c    |   6 +
  lib/efi_loader/helloworld.c       | 167 ++++++++++++++++----
  lib/efi_selftest/dtbdump.c        | 310
++++++++++++++++++++++++++++++++-----
  net/tftp.c                        |   9 +-
  tools/efivar.py                   |  39 ++---
  21 files changed, 1096 insertions(+), 354 deletions(-)
  create mode 100644 include/efi_dt_fixup.h
  create mode 100644 lib/efi_loader/efi_dt_fixup.c
Reply | Threaded
Open this post in threaded view
|

Re: Pull request for UEFI sub-system for efi-2021-04-rc1

Tom Rini-4
On Wed, Jan 13, 2021 at 07:43:56PM +0100, Heinrich Schuchardt wrote:

> Dear Tom,
>
> The following changes since commit ee6726be4f0dccb612f0193c62ca149164c8a5af:
>
>   Merge tag 'ti-v2021.04-rc1' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-ti (2021-01-12 09:32:48
> -0500)
>
> are available in the Git repository at:
>
>   https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git
> tags/efi-2021-04-rc1
>
> for you to fetch changes up to 8e70f1cb3f2c18d574b087d4fc1d79e68ce98fa9:
>
>   efi_selftest: dtbdump support EFI_DT_FIXUP_PROTOCOL (2021-01-13
> 02:38:01 +0100)
>
> Gitlab showed no problems:
> https://gitlab.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/5854
>
Applied to u-boot/master, thanks!

But!  This got me to look a little harder at things and even if we have
a platform where we disable ext4/fat write support, there's no change in
the EFI side of the code.  Is this something we can do anything about?
If so, is it worthwhile or likely to really only change a few boards and
I'm just grasping at straws, so to speak, on the question of "Can we do
anything to reduce EFI code size" ?

--
Tom

signature.asc (673 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Pull request for UEFI sub-system for efi-2021-04-rc1

Heinrich Schuchardt
On 14.01.21 20:24, Tom Rini wrote:

> On Wed, Jan 13, 2021 at 07:43:56PM +0100, Heinrich Schuchardt wrote:
>
>> Dear Tom,
>>
>> The following changes since commit ee6726be4f0dccb612f0193c62ca149164c8a5af:
>>
>>   Merge tag 'ti-v2021.04-rc1' of
>> https://gitlab.denx.de/u-boot/custodians/u-boot-ti (2021-01-12 09:32:48
>> -0500)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git
>> tags/efi-2021-04-rc1
>>
>> for you to fetch changes up to 8e70f1cb3f2c18d574b087d4fc1d79e68ce98fa9:
>>
>>   efi_selftest: dtbdump support EFI_DT_FIXUP_PROTOCOL (2021-01-13
>> 02:38:01 +0100)
>>
>> Gitlab showed no problems:
>> https://gitlab.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/5854
>>
>
> Applied to u-boot/master, thanks!
>
> But!  This got me to look a little harder at things and even if we have
> a platform where we disable ext4/fat write support, there's no change in
> the EFI side of the code.  Is this something we can do anything about?
> If so, is it worthwhile or likely to really only change a few boards and
> I'm just grasping at straws, so to speak, on the question of "Can we do
> anything to reduce EFI code size" ?

I assume you already have disabled:
CONFIG_EFI_DEVICE_PATH_TO_TEXT
CONFIG_EFI_LOADER_HII
CONFIG_EFI_UNICODE_COLLATION_PROTOCOL2

Could you, please, give me an example config to work on?

Best regards

Heinrich