[PATCH] w1: mxc: fix build

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] w1: mxc: fix build

Martin Fuzzey-2
Now that header files no longer include common.h it must be included
first.

Otherwise the build fails with errors like
        include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
         u32 imx_get_uartclk(void);

Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files")

Signed-off-by: Martin Fuzzey <[hidden email]>
---
 drivers/w1/mxc_w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/mxc_w1.c b/drivers/w1/mxc_w1.c
index 8e6372f..3aeaaf5 100644
--- a/drivers/w1/mxc_w1.c
+++ b/drivers/w1/mxc_w1.c
@@ -17,8 +17,8 @@
  * Martin Fuzzey <[hidden email]>
  */
 
-#include <asm/arch/clock.h>
 #include <common.h>
+#include <asm/arch/clock.h>
 #include <dm.h>
 #include <dm/device_compat.h>
 #include <linux/bitops.h>
--
1.9.1

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] w1: mxc: fix build

Simon Glass-3
On Wed, 13 Jan 2021 at 03:21, Martin Fuzzey
<[hidden email]> wrote:

>
> Now that header files no longer include common.h it must be included
> first.
>
> Otherwise the build fails with errors like
>         include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
>          u32 imx_get_uartclk(void);
>
> Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files")
>
> Signed-off-by: Martin Fuzzey <[hidden email]>
> ---
>  drivers/w1/mxc_w1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <[hidden email]>
Reply | Threaded
Open this post in threaded view
|

[PATCH] w1: mxc: fix build

sbabic
In reply to this post by Martin Fuzzey-2
> Now that header files no longer include common.h it must be included
> first.
> Otherwise the build fails with errors like
> include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
> u32 imx_get_uartclk(void);
> Fixes: c3dc39a2f85b ("arm: Don't include common.h in header files")
> Signed-off-by: Martin Fuzzey <[hidden email]>
> Reviewed-by: Simon Glass <[hidden email]>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [hidden email]
=====================================================================