[PATCH v3] drivers: serial: probe all uart devices

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v3] drivers: serial: probe all uart devices

Vabhav Sharma (OSS)
From: Vabhav Sharma <[hidden email]>

U-Boot DM model probe only single device at a time
which is enabled and configured using device tree
or platform data method.

PL011 UART IP is SBSA compliant and firmware does the
serial port set-up, initialization and let the kernel use
UART port for sending and receiving characters.

Normally software talk to one serial port time but some
LayerScape platform require all the UART devices enabled
in Linux for various use case.

Adding support to probe all enabled serial devices like SBSA
compliant PL011 UART ports probe and initialization by firmware.

Signed-off-by: Vabhav Sharma <[hidden email]>
--
v3:
  Incorporated Simon and Stephan review comment
  - Define generic function uclass_probe_all(enum uclass_id)
    in drivers/core/uclass.c
  - Added the function in caller of serial_find_console_or_panic()
  - Removed repeated sequence with generic function call uclass_probe_all()
  - Dependent on other patch [PATCH] dm: core: add function uclass_probe_all()
    to probe all devices

v2:
  Incorporated Stefan review comment, Update #ifdef with macro
  if (IS_ENABLED)..
---
 drivers/serial/Kconfig         | 17 +++++++++++++++++
 drivers/serial/serial-uclass.c |  4 ++++
 2 files changed, 21 insertions(+)

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index b4805a2..af8779b 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -134,6 +134,23 @@ config SERIAL_SEARCH_ALL
 
   If unsure, say N.
 
+config SERIAL_PROBE_ALL
+ bool "Probe all available serial devices"
+ depends on DM_SERIAL
+ default n
+ help
+  The serial subsystem only probe for single serial device,
+  but does not probe for other remaining serial devices.
+  With this option set,we make probing and searching for
+  all available devices optional.
+  Normally, U-Boot talk to one serial port at a time but SBSA
+  compliant UART devices like PL011 require initialization
+  by firmware and let the kernel use serial port for sending
+  and receiving the characters.
+
+  If probing is not required for all remaining available
+  devices other than default current console device, say N.
+
 config SPL_DM_SERIAL
  bool "Enable Driver Model for serial drivers in SPL"
  depends on DM_SERIAL && SPL_DM
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index 0027625..09bc6f4 100644
--- a/drivers/serial/serial-uclass.c
+++ b/drivers/serial/serial-uclass.c
@@ -172,6 +172,10 @@ int serial_init(void)
 /* Called after relocation */
 int serial_initialize(void)
 {
+ /* Scanning uclass to probe devices */
+ if (IS_ENABLED(CONFIG_SERIAL_PROBE_ALL))
+ uclass_probe_all(UCLASS_SERIAL);
+
  return serial_init();
 }
 
--
2.7.4

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3] drivers: serial: probe all uart devices

Stefan Roese
On 19.10.20 11:53, Vabhav Sharma wrote:

> From: Vabhav Sharma <[hidden email]>
>
> U-Boot DM model probe only single device at a time
> which is enabled and configured using device tree
> or platform data method.
>
> PL011 UART IP is SBSA compliant and firmware does the
> serial port set-up, initialization and let the kernel use
> UART port for sending and receiving characters.
>
> Normally software talk to one serial port time but some
> LayerScape platform require all the UART devices enabled
> in Linux for various use case.
>
> Adding support to probe all enabled serial devices like SBSA
> compliant PL011 UART ports probe and initialization by firmware.
>
> Signed-off-by: Vabhav Sharma <[hidden email]>
> --
> v3:
>    Incorporated Simon and Stephan review comment
>    - Define generic function uclass_probe_all(enum uclass_id)
>      in drivers/core/uclass.c

Hmmm, seems to be missing (see below).

>    - Added the function in caller of serial_find_console_or_panic()
>    - Removed repeated sequence with generic function call uclass_probe_all()
>    - Dependent on other patch [PATCH] dm: core: add function uclass_probe_all()
>      to probe all devices
>
> v2:
>    Incorporated Stefan review comment, Update #ifdef with macro
>    if (IS_ENABLED)..
> ---
>   drivers/serial/Kconfig         | 17 +++++++++++++++++
>   drivers/serial/serial-uclass.c |  4 ++++
>   2 files changed, 21 insertions(+)
>
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index b4805a2..af8779b 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -134,6 +134,23 @@ config SERIAL_SEARCH_ALL
>  
>    If unsure, say N.
>  
> +config SERIAL_PROBE_ALL
> + bool "Probe all available serial devices"
> + depends on DM_SERIAL
> + default n

Not needed as it's default?

> + help
> +  The serial subsystem only probe for single serial device,
> +  but does not probe for other remaining serial devices.
> +  With this option set,we make probing and searching for
> +  all available devices optional.
> +  Normally, U-Boot talk to one serial port at a time but SBSA
> +  compliant UART devices like PL011 require initialization
> +  by firmware and let the kernel use serial port for sending
> +  and receiving the characters.
> +
> +  If probing is not required for all remaining available
> +  devices other than default current console device, say N.
> +
>   config SPL_DM_SERIAL
>   bool "Enable Driver Model for serial drivers in SPL"
>   depends on DM_SERIAL && SPL_DM
> diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
> index 0027625..09bc6f4 100644
> --- a/drivers/serial/serial-uclass.c
> +++ b/drivers/serial/serial-uclass.c
> @@ -172,6 +172,10 @@ int serial_init(void)
>   /* Called after relocation */
>   int serial_initialize(void)
>   {
> + /* Scanning uclass to probe devices */
> + if (IS_ENABLED(CONFIG_SERIAL_PROBE_ALL))
> + uclass_probe_all(UCLASS_SERIAL);
> +
>   return serial_init();
>   }

So where is the uclass_probe_all() function defined? You seem to have
missed something in your patch.

Thanks,
Stefan