[PATCH v3] arm: vexpress: don't reset flags in board_init to avoid losing previous ones

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v3] arm: vexpress: don't reset flags in board_init to avoid losing previous ones

Arnaud Aujon Chevallier
Re-submitted because of missing description and signed-off.

flags reset in board_init caused bugs when executing command like editenv
because the reallocated flag was lost.

Signed-off-by: Arnaud Aujon Chevallier <[hidden email]>

---
 board/armltd/vexpress/vexpress_common.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/board/armltd/vexpress/vexpress_common.c b/board/armltd/vexpress/vexpress_common.c
index 70f6cd80d5..8fea8ff352 100644
--- a/board/armltd/vexpress/vexpress_common.c
+++ b/board/armltd/vexpress/vexpress_common.c
@@ -55,7 +55,6 @@ int board_init(void)
 {
  gd->bd->bi_boot_params = LINUX_BOOT_PARAM_ADDR;
  gd->bd->bi_arch_number = MACH_TYPE_VEXPRESS;
- gd->flags = 0;
 
  icache_enable();
  flash__init();
--
2.26.2

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3] arm: vexpress: don't reset flags in board_init to avoid losing previous ones

Michael Opdenacker
Tested-by: Michael Opdenacker <[hidden email]>

--
Michael Opdenacker, CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3] arm: vexpress: don't reset flags in board_init to avoid losing previous ones

Tom Rini-4
In reply to this post by Arnaud Aujon Chevallier
On Sun, Nov 15, 2020 at 12:54:10PM +0100, Arnaud Aujon Chevallier wrote:

> Re-submitted because of missing description and signed-off.
>
> flags reset in board_init caused bugs when executing command like editenv
> because the reallocated flag was lost.
>
> Tested-by: Michael Opdenacker <[hidden email]>
> Signed-off-by: Arnaud Aujon Chevallier <[hidden email]>

Applied to u-boot/master, thanks!

--
Tom

signature.asc (673 bytes) Download Attachment