[PATCH v3 0/2] dm: core: drivers: add function uclass_probe_all()

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v3 0/2] dm: core: drivers: add function uclass_probe_all()

Vabhav Sharma (OSS)
From: Vabhav Sharma <[hidden email]>

- Add common method to probe devices belonging to same uclass
- Add config in serial uclass to support optional inclusion of uclass_probe_all
- Enable support for available serial devices probe

Changes for v3:
  Incorporated Simon and Stephan review comment
  - Define generic function uclass_probe_all(enum uclass_id)
    in drivers/core/uclass.c
  - Added the function in caller of serial_find_console_or_panic()
  - Removed repeated sequence with generic function call uclass_probe_all()
 
Changes for v2:
  Incorporated Stefan review comment,Update #ifdef with macro if (IS_ENABLED).

Vabhav Sharma (2):
  dm: core: add function uclass_probe_all() to probe all devices
  drivers: serial: probe all uart devices

 drivers/core/uclass.c          | 17 +++++++++++++++++
 drivers/serial/Kconfig         | 17 +++++++++++++++++
 drivers/serial/serial-uclass.c |  4 ++++
 include/dm/uclass.h            | 12 ++++++++++++
 4 files changed, 50 insertions(+)

--
2.7.4

Reply | Threaded
Open this post in threaded view
|

[PATCH v3 1/2] dm: core: add function uclass_probe_all() to probe all devices

Vabhav Sharma (OSS)
From: Vabhav Sharma <[hidden email]>

Support a common method to probe all devices associated with uclass.

This includes data structures and code for finding the first device and
looping for remaining devices associated with uclasses (groups of devices
with the same purpose, e.g. all SERIAL ports will be in the same uclass).

An example is SBSA compliant PL011 UART IP, where firmware does the serial
port initialization and prepare uart device to let the kernel use it for
sending and reveiving the characters.SERIAL uclass will use this function
to initialize PL011 UART ports.

The feature is enabled with CONFIG_DM.

Signed-off-by: Vabhav Sharma <[hidden email]>
Reviewed-by: Stefan Roese <[hidden email]>
--
  v3:
  Incorporated review comments of Stephan,Simon
  Related discussion https://patchwork.ozlabs.org/project/uboot/patch/1601400
[hidden email]/
---
 drivers/core/uclass.c | 17 +++++++++++++++++
 include/dm/uclass.h   | 12 ++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c
index c3f1b73..0725e8e 100644
--- a/drivers/core/uclass.c
+++ b/drivers/core/uclass.c
@@ -792,6 +792,23 @@ int uclass_pre_remove_device(struct udevice *dev)
 }
 #endif
 
+int uclass_probe_all(enum uclass_id id)
+{
+ struct udevice *dev;
+ int ret;
+
+ ret = uclass_first_device(id, &dev);
+ if (ret || !dev)
+ return ret;
+ if (dev) {
+ /* Scanning uclass to probe all devices */
+ for (; dev; uclass_next_device(&dev))
+ ;
+ }
+
+ return 0;
+}
+
 UCLASS_DRIVER(nop) = {
  .id = UCLASS_NOP,
  .name = "nop",
diff --git a/include/dm/uclass.h b/include/dm/uclass.h
index 67ff746..0fce83f 100644
--- a/include/dm/uclass.h
+++ b/include/dm/uclass.h
@@ -380,6 +380,18 @@ int uclass_first_device_drvdata(enum uclass_id id, ulong driver_data,
 int uclass_resolve_seq(struct udevice *dev);
 
 /**
+ * uclass_probe_all() - Probe all devices based on an uclass ID
+ *
+ * Every uclass is identified by an ID, a number from 0 to n-1 where n is
+ * the number of uclasses. This function probe all devices asocciated with
+ * a uclass by looking its ID.
+ *
+ * @id: uclass ID to look up
+ * @return 0 if OK, other -ve on error
+ */
+int uclass_probe_all(enum uclass_id id);
+
+/**
  * uclass_id_foreach_dev() - Helper function to iteration through devices
  *
  * This creates a for() loop which works through the available devices in
--
2.7.4

Reply | Threaded
Open this post in threaded view
|

[PATCH v3 2/2] drivers: serial: probe all uart devices

Vabhav Sharma (OSS)
In reply to this post by Vabhav Sharma (OSS)
From: Vabhav Sharma <[hidden email]>

U-Boot DM model probe only single device at a time
which is enabled and configured using device tree
or platform data method.

PL011 UART IP is SBSA compliant and firmware does the
serial port set-up, initialization and let the kernel use
UART port for sending and receiving characters.

Normally software talk to one serial port time but some
LayerScape platform require all the UART devices enabled
in Linux for various use case.

Adding support to probe all enabled serial devices like SBSA
compliant PL011 UART ports probe and initialization by firmware.

Signed-off-by: Vabhav Sharma <[hidden email]>
Reviewed-by: Stefan Roese <[hidden email]>
--
v3:
  Incorporated Simon and Stephan review comment
  - Define generic function uclass_probe_all(enum uclass_id)
    in drivers/core/uclass.c
  - Added the function in caller of serial_find_console_or_panic()
  - Removed repeated sequence with generic function call uclass_probe_all()
  - Dependent on other patch [PATCH] dm: core: add function uclass_probe_all()
    to probe all devices

v2:
  Incorporated Stefan review comment, Update #ifdef with macro
  if (IS_ENABLED)..
---
 drivers/serial/Kconfig         | 17 +++++++++++++++++
 drivers/serial/serial-uclass.c |  4 ++++
 2 files changed, 21 insertions(+)

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index b4805a2..af8779b 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -134,6 +134,23 @@ config SERIAL_SEARCH_ALL
 
   If unsure, say N.
 
+config SERIAL_PROBE_ALL
+ bool "Probe all available serial devices"
+ depends on DM_SERIAL
+ default n
+ help
+  The serial subsystem only probe for single serial device,
+  but does not probe for other remaining serial devices.
+  With this option set,we make probing and searching for
+  all available devices optional.
+  Normally, U-Boot talk to one serial port at a time but SBSA
+  compliant UART devices like PL011 require initialization
+  by firmware and let the kernel use serial port for sending
+  and receiving the characters.
+
+  If probing is not required for all remaining available
+  devices other than default current console device, say N.
+
 config SPL_DM_SERIAL
  bool "Enable Driver Model for serial drivers in SPL"
  depends on DM_SERIAL && SPL_DM
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index 0027625..09bc6f4 100644
--- a/drivers/serial/serial-uclass.c
+++ b/drivers/serial/serial-uclass.c
@@ -172,6 +172,10 @@ int serial_init(void)
 /* Called after relocation */
 int serial_initialize(void)
 {
+ /* Scanning uclass to probe devices */
+ if (IS_ENABLED(CONFIG_SERIAL_PROBE_ALL))
+ uclass_probe_all(UCLASS_SERIAL);
+
  return serial_init();
 }
 
--
2.7.4

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v3 1/2] dm: core: add function uclass_probe_all() to probe all devices

Simon Glass-3
In reply to this post by Vabhav Sharma (OSS)
On Mon, 19 Oct 2020 at 12:10, Vabhav Sharma <[hidden email]> wrote:

>
> From: Vabhav Sharma <[hidden email]>
>
> Support a common method to probe all devices associated with uclass.
>
> This includes data structures and code for finding the first device and
> looping for remaining devices associated with uclasses (groups of devices
> with the same purpose, e.g. all SERIAL ports will be in the same uclass).
>
> An example is SBSA compliant PL011 UART IP, where firmware does the serial
> port initialization and prepare uart device to let the kernel use it for
> sending and reveiving the characters.SERIAL uclass will use this function
> to initialize PL011 UART ports.
>
> The feature is enabled with CONFIG_DM.
>
> Signed-off-by: Vabhav Sharma <[hidden email]>
> Reviewed-by: Stefan Roese <[hidden email]>
> --
>   v3:
>   Incorporated review comments of Stephan,Simon
>   Related discussion https://patchwork.ozlabs.org/project/uboot/patch/1601400
> [hidden email]/
> ---
>  drivers/core/uclass.c | 17 +++++++++++++++++
>  include/dm/uclass.h   | 12 ++++++++++++
>  2 files changed, 29 insertions(+)

Reviewed-by: Simon Glass <[hidden email]>

>
> diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c
> index c3f1b73..0725e8e 100644
> --- a/drivers/core/uclass.c
> +++ b/drivers/core/uclass.c
> @@ -792,6 +792,23 @@ int uclass_pre_remove_device(struct udevice *dev)
>  }
>  #endif
>
> +int uclass_probe_all(enum uclass_id id)
> +{
> +       struct udevice *dev;
> +       int ret;
> +
> +       ret = uclass_first_device(id, &dev);
> +       if (ret || !dev)
> +               return ret;
> +       if (dev) {

nit: I think that if() is not needed.


> +               /* Scanning uclass to probe all devices */
> +               for (; dev; uclass_next_device(&dev))
> +                       ;
> +       }
> +
> +       return 0;
> +}
> +
>  UCLASS_DRIVER(nop) = {
>         .id             = UCLASS_NOP,
>         .name           = "nop",
> diff --git a/include/dm/uclass.h b/include/dm/uclass.h
> index 67ff746..0fce83f 100644
> --- a/include/dm/uclass.h
> +++ b/include/dm/uclass.h
> @@ -380,6 +380,18 @@ int uclass_first_device_drvdata(enum uclass_id id, ulong driver_data,
>  int uclass_resolve_seq(struct udevice *dev);
>
>  /**
> + * uclass_probe_all() - Probe all devices based on an uclass ID
> + *
> + * Every uclass is identified by an ID, a number from 0 to n-1 where n is
> + * the number of uclasses. This function probe all devices asocciated with
> + * a uclass by looking its ID.
> + *
> + * @id: uclass ID to look up
> + * @return 0 if OK, other -ve on error
> + */
> +int uclass_probe_all(enum uclass_id id);
> +
> +/**
>   * uclass_id_foreach_dev() - Helper function to iteration through devices
>   *
>   * This creates a for() loop which works through the available devices in
> --
> 2.7.4
>
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH v3 1/2] dm: core: add function uclass_probe_all() to probe all devices

Vabhav Sharma (OSS)


> -----Original Message-----
> From: Simon Glass <[hidden email]>
> Sent: Tuesday, October 27, 2020 10:22 AM
> To: Vabhav Sharma (OSS) <[hidden email]>
> Cc: Stefan Roese <[hidden email]>; U-Boot Mailing List <[hidden email]>;
> Varun Sethi <[hidden email]>; Andre Przywara
> <[hidden email]>; Vabhav Sharma <[hidden email]>
> Subject: Re: [PATCH v3 1/2] dm: core: add function uclass_probe_all() to
> probe all devices
>
> On Mon, 19 Oct 2020 at 12:10, Vabhav Sharma
> <[hidden email]> wrote:
> >
> > From: Vabhav Sharma <[hidden email]>
> >
> > Support a common method to probe all devices associated with uclass.
> >
> > This includes data structures and code for finding the first device
> > and looping for remaining devices associated with uclasses (groups of
> > devices with the same purpose, e.g. all SERIAL ports will be in the same
> uclass).
> >
> > An example is SBSA compliant PL011 UART IP, where firmware does the
> > serial port initialization and prepare uart device to let the kernel
> > use it for sending and reveiving the characters.SERIAL uclass will use
> > this function to initialize PL011 UART ports.
> >
> > The feature is enabled with CONFIG_DM.
> >
> > Signed-off-by: Vabhav Sharma <[hidden email]>
> > Reviewed-by: Stefan Roese <[hidden email]>
> > --
> >   v3:
> >   Incorporated review comments of Stephan,Simon
> >   Related discussion
> > https://patchwork.ozlabs.org/project/uboot/patch/1601400
> > [hidden email]/
> > ---
> >  drivers/core/uclass.c | 17 +++++++++++++++++
> >  include/dm/uclass.h   | 12 ++++++++++++
> >  2 files changed, 29 insertions(+)
>
> Reviewed-by: Simon Glass <[hidden email]>
>
> >
> > diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index
> > c3f1b73..0725e8e 100644
> > --- a/drivers/core/uclass.c
> > +++ b/drivers/core/uclass.c
> > @@ -792,6 +792,23 @@ int uclass_pre_remove_device(struct udevice *dev)
> > }  #endif
> >
> > +int uclass_probe_all(enum uclass_id id) {
> > +       struct udevice *dev;
> > +       int ret;
> > +
> > +       ret = uclass_first_device(id, &dev);
> > +       if (ret || !dev)
> > +               return ret;
> > +       if (dev) {
>
> nit: I think that if() is not needed.
Sure

>
>
> > +               /* Scanning uclass to probe all devices */
> > +               for (; dev; uclass_next_device(&dev))
> > +                       ;
> > +       }
> > +
> > +       return 0;
> > +}
> > +
> >  UCLASS_DRIVER(nop) = {
> >         .id             = UCLASS_NOP,
> >         .name           = "nop",
> > diff --git a/include/dm/uclass.h b/include/dm/uclass.h index
> > 67ff746..0fce83f 100644
> > --- a/include/dm/uclass.h
> > +++ b/include/dm/uclass.h
> > @@ -380,6 +380,18 @@ int uclass_first_device_drvdata(enum uclass_id
> > id, ulong driver_data,  int uclass_resolve_seq(struct udevice *dev);
> >
> >  /**
> > + * uclass_probe_all() - Probe all devices based on an uclass ID
> > + *
> > + * Every uclass is identified by an ID, a number from 0 to n-1 where
> > +n is
> > + * the number of uclasses. This function probe all devices asocciated
> > +with
> > + * a uclass by looking its ID.
> > + *
> > + * @id: uclass ID to look up
> > + * @return 0 if OK, other -ve on error  */ int uclass_probe_all(enum
> > +uclass_id id);
> > +
> > +/**
> >   * uclass_id_foreach_dev() - Helper function to iteration through devices
> >   *
> >   * This creates a for() loop which works through the available
> > devices in
> > --
> > 2.7.4
> >