[PATCH v2] sunxi: add PineCube board

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v2] sunxi: add PineCube board

Icenowy Zheng-2
PineCube is an IP camera development kit released by Pine64.

It comes with the following compoents:

- A mainboard with Sochip S3 SoC, a 16MByte SPI Flash, AXP209 PMIC,
a power-only microUSB connector, a USB Type-A connector, a 10/100Mbps
Ethernet port and FPC connectors for camera and daughter board.
- An OV5640-based camera module which is connected to the parallel CSI
bus of the mainboard.
- A daughterboard with several buttons, a SD slot, some IR LEDs, a
microphone and a speaker connector.

As the device tree is synchronized in a previous commit, just add
MAINTAINER item and a defconfig.

Signed-off-by: Icenowy Zheng <[hidden email]>
---
Changes in v2:
- Removed LDO3 hack in U-Boot because LDO3 is kept disabled in U-Boot.

 board/sunxi/MAINTAINERS    |  5 +++++
 configs/pinecube_defconfig | 15 +++++++++++++++
 2 files changed, 20 insertions(+)
 create mode 100644 configs/pinecube_defconfig

diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
index d3755ae41a..735801ae1d 100644
--- a/board/sunxi/MAINTAINERS
+++ b/board/sunxi/MAINTAINERS
@@ -440,6 +440,11 @@ M: Vasily Khoruzhick <[hidden email]>
 S: Maintained
 F: configs/pinebook_defconfig
 
+PINECUBE BOARD:
+M: Icenowy Zheng <[hidden email]>
+S: Maintained
+F: configs/pinecube_defconfig
+
 PINE64 BOARDS
 M: Andre Przywara <[hidden email]>
 S: Maintained
diff --git a/configs/pinecube_defconfig b/configs/pinecube_defconfig
new file mode 100644
index 0000000000..a8c404f6b1
--- /dev/null
+++ b/configs/pinecube_defconfig
@@ -0,0 +1,15 @@
+CONFIG_ARM=y
+CONFIG_ARCH_SUNXI=y
+CONFIG_SPL=y
+CONFIG_MACH_SUN8I_V3S=y
+CONFIG_SUNXI_DRAM_DDR3_1333=y
+CONFIG_DRAM_CLK=504
+CONFIG_DRAM_ODT_EN=y
+CONFIG_I2C0_ENABLE=y
+CONFIG_DEFAULT_DEVICE_TREE="sun8i-s3-pinecube"
+CONFIG_SPL_I2C_SUPPORT=y
+# CONFIG_NETDEVICES is not set
+CONFIG_AXP209_POWER=y
+CONFIG_AXP_DCDC2_VOLT=1250
+CONFIG_AXP_DCDC3_VOLT=3300
+CONFIG_CONS_INDEX=3
--
2.28.0
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2] sunxi: add PineCube board

André Przywara
On 18/11/2020 06:29, Icenowy Zheng wrote:

> PineCube is an IP camera development kit released by Pine64.
>
> It comes with the following compoents:
>
> - A mainboard with Sochip S3 SoC, a 16MByte SPI Flash, AXP209 PMIC,
> a power-only microUSB connector, a USB Type-A connector, a 10/100Mbps
> Ethernet port and FPC connectors for camera and daughter board.
> - An OV5640-based camera module which is connected to the parallel CSI
> bus of the mainboard.
> - A daughterboard with several buttons, a SD slot, some IR LEDs, a
> microphone and a speaker connector.
>
> As the device tree is synchronized in a previous commit,

It was, but it is missing the line in the dts Makefile:
...
dts/Makefile:33: recipe for target 'arch/arm/dts/sun8i-s3-pinecube.dtb'
failed
...

Can you please add this and resend?

And out of curiosity: what's with the Ethernet? Looks like a
straight-forward sun8i-emac, doesn't it?

Cheers,
Andre

> just add MAINTAINER item and a defconfig.
>
> Signed-off-by: Icenowy Zheng <[hidden email]>
> ---
> Changes in v2:
> - Removed LDO3 hack in U-Boot because LDO3 is kept disabled in U-Boot.
>
>  board/sunxi/MAINTAINERS    |  5 +++++
>  configs/pinecube_defconfig | 15 +++++++++++++++
>  2 files changed, 20 insertions(+)
>  create mode 100644 configs/pinecube_defconfig
>
> diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
> index d3755ae41a..735801ae1d 100644
> --- a/board/sunxi/MAINTAINERS
> +++ b/board/sunxi/MAINTAINERS
> @@ -440,6 +440,11 @@ M: Vasily Khoruzhick <[hidden email]>
>  S: Maintained
>  F: configs/pinebook_defconfig
>  
> +PINECUBE BOARD:
> +M: Icenowy Zheng <[hidden email]>
> +S: Maintained
> +F: configs/pinecube_defconfig
> +
>  PINE64 BOARDS
>  M: Andre Przywara <[hidden email]>
>  S: Maintained
> diff --git a/configs/pinecube_defconfig b/configs/pinecube_defconfig
> new file mode 100644
> index 0000000000..a8c404f6b1
> --- /dev/null
> +++ b/configs/pinecube_defconfig
> @@ -0,0 +1,15 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_SUNXI=y
> +CONFIG_SPL=y
> +CONFIG_MACH_SUN8I_V3S=y
> +CONFIG_SUNXI_DRAM_DDR3_1333=y
> +CONFIG_DRAM_CLK=504
> +CONFIG_DRAM_ODT_EN=y
> +CONFIG_I2C0_ENABLE=y
> +CONFIG_DEFAULT_DEVICE_TREE="sun8i-s3-pinecube"
> +CONFIG_SPL_I2C_SUPPORT=y
> +# CONFIG_NETDEVICES is not set
> +CONFIG_AXP209_POWER=y
> +CONFIG_AXP_DCDC2_VOLT=1250
> +CONFIG_AXP_DCDC3_VOLT=3300
> +CONFIG_CONS_INDEX=3
>