[PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

Andy Shevchenko-2
It seems nobody tested the debug() option in spin_lock_irqsave().
Currently, when #define DEBUG, it spoils the compiler with

In file included from drivers/usb/dwc3/gadget.c:18:
drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’:
include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized]
  235 |    printf(pr_fmt(fmt), ##args); \
      |    ^~~~~~
drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here
 1347 |  unsigned long  flags;
      |                 ^~~~~

and so on...
Drop useless debug() call to make compiler happy.

Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h")
Cc: Heiko Schocher <[hidden email]>
Cc: Tom Rini <[hidden email]>
Signed-off-by: Andy Shevchenko <[hidden email]>
---
 include/linux/compat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compat.h b/include/linux/compat.h
index 38549baa251d..3d0acbd582ef 100644
--- a/include/linux/compat.h
+++ b/include/linux/compat.h
@@ -248,7 +248,7 @@ typedef int wait_queue_head_t;
 #define spin_lock_init(lock) do {} while (0)
 #define spin_lock(lock) do {} while (0)
 #define spin_unlock(lock) do {} while (0)
-#define spin_lock_irqsave(lock, flags) do { debug("%lu\n", flags); } while (0)
+#define spin_lock_irqsave(lock, flags) do {} while (0)
 #define spin_unlock_irqrestore(lock, flags) do { flags = 0; } while (0)
 
 #define DEFINE_MUTEX(...)
--
2.29.2

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

Andy Shevchenko
Update Tom's address

On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko
<[hidden email]> wrote:

>
> It seems nobody tested the debug() option in spin_lock_irqsave().
> Currently, when #define DEBUG, it spoils the compiler with
>
> In file included from drivers/usb/dwc3/gadget.c:18:
> drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’:
> include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized]
>   235 |    printf(pr_fmt(fmt), ##args); \
>       |    ^~~~~~
> drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here
>  1347 |  unsigned long  flags;
>       |                 ^~~~~
>
> and so on...
> Drop useless debug() call to make compiler happy.
>
> Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h")
> Cc: Heiko Schocher <[hidden email]>
> Cc: Tom Rini <[hidden email]>
> Signed-off-by: Andy Shevchenko <[hidden email]>
> ---
>  include/linux/compat.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compat.h b/include/linux/compat.h
> index 38549baa251d..3d0acbd582ef 100644
> --- a/include/linux/compat.h
> +++ b/include/linux/compat.h
> @@ -248,7 +248,7 @@ typedef int wait_queue_head_t;
>  #define spin_lock_init(lock) do {} while (0)
>  #define spin_lock(lock) do {} while (0)
>  #define spin_unlock(lock) do {} while (0)
> -#define spin_lock_irqsave(lock, flags) do { debug("%lu\n", flags); } while (0)
> +#define spin_lock_irqsave(lock, flags) do {} while (0)
>  #define spin_unlock_irqrestore(lock, flags) do { flags = 0; } while (0)
>
>  #define DEFINE_MUTEX(...)
> --
> 2.29.2
>


--
With Best Regards,
Andy Shevchenko
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

Oleksandr Andrushchenko-2
Hi, Andy

On 11/19/20 10:21 PM, Andy Shevchenko wrote:

> Update Tom's address
>
> On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko
> <[hidden email]> wrote:
>> It seems nobody tested the debug() option in spin_lock_irqsave().
>> Currently, when #define DEBUG, it spoils the compiler with
>>
>> In file included from drivers/usb/dwc3/gadget.c:18:
>> drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’:
>> include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized]
>>    235 |    printf(pr_fmt(fmt), ##args); \
>>        |    ^~~~~~
>> drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here
>>   1347 |  unsigned long  flags;
>>        |                 ^~~~~
>>
>> and so on...
>> Drop useless debug() call to make compiler happy.
>>
>> Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h")
>> Cc: Heiko Schocher <[hidden email]>
>> Cc: Tom Rini <[hidden email]>
>> Signed-off-by: Andy Shevchenko <[hidden email]>
Reviewed-by: Oleksandr Andrushchenko <[hidden email]>

>> ---
>>   include/linux/compat.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/compat.h b/include/linux/compat.h
>> index 38549baa251d..3d0acbd582ef 100644
>> --- a/include/linux/compat.h
>> +++ b/include/linux/compat.h
>> @@ -248,7 +248,7 @@ typedef int wait_queue_head_t;
>>   #define spin_lock_init(lock) do {} while (0)
>>   #define spin_lock(lock) do {} while (0)
>>   #define spin_unlock(lock) do {} while (0)
>> -#define spin_lock_irqsave(lock, flags) do { debug("%lu\n", flags); } while (0)
>> +#define spin_lock_irqsave(lock, flags) do {} while (0)
>>   #define spin_unlock_irqrestore(lock, flags) do { flags = 0; } while (0)
>>
>>   #define DEFINE_MUTEX(...)
>> --
>> 2.29.2
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

Heiko Schocher denx
In reply to this post by Andy Shevchenko
Hello Andy,

Am 19.11.20 um 21:21 schrieb Andy Shevchenko:

> Update Tom's address
>
> On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko
> <[hidden email]> wrote:
>>
>> It seems nobody tested the debug() option in spin_lock_irqsave().
>> Currently, when #define DEBUG, it spoils the compiler with
>>
>> In file included from drivers/usb/dwc3/gadget.c:18:
>> drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’:
>> include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized]
>>   235 |    printf(pr_fmt(fmt), ##args); \
>>       |    ^~~~~~
>> drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here
>>  1347 |  unsigned long  flags;
>>       |                 ^~~~~
>>
>> and so on...
>> Drop useless debug() call to make compiler happy.
>>
>> Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h")
>> Cc: Heiko Schocher <[hidden email]>
>> Cc: Tom Rini <[hidden email]>
>> Signed-off-by: Andy Shevchenko <[hidden email]>
>> ---
>>  include/linux/compat.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Reviewed-by: Heiko Schocher <[hidden email]>

bye,
Heiko
--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

Andy Shevchenko-2
In reply to this post by Andy Shevchenko
On Thu, Nov 19, 2020 at 10:21:39PM +0200, Andy Shevchenko wrote:
> Update Tom's address

Tom, should I resend with your address fixed?

--
With Best Regards,
Andy Shevchenko


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

Tom Rini-4
On Wed, Dec 02, 2020 at 08:28:55PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 19, 2020 at 10:21:39PM +0200, Andy Shevchenko wrote:
> > Update Tom's address
>
> Tom, should I resend with your address fixed?

No, I grab things from patchwork.  This is on my TODO list, btw.

--
Tom

signature.asc (673 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

Andy Shevchenko-2
On Wed, Dec 02, 2020 at 01:37:35PM -0500, Tom Rini wrote:
> On Wed, Dec 02, 2020 at 08:28:55PM +0200, Andy Shevchenko wrote:
> > On Thu, Nov 19, 2020 at 10:21:39PM +0200, Andy Shevchenko wrote:
> > > Update Tom's address
> >
> > Tom, should I resend with your address fixed?
>
> No, I grab things from patchwork.  This is on my TODO list, btw.

Cool, thanks!

--
With Best Regards,
Andy Shevchenko


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v1] linux/compat.h: Remove debug() from spin_lock_irqsave()

Tom Rini-4
In reply to this post by Andy Shevchenko-2
On Thu, Nov 19, 2020 at 09:26:20PM +0200, Andy Shevchenko wrote:

> It seems nobody tested the debug() option in spin_lock_irqsave().
> Currently, when #define DEBUG, it spoils the compiler with
>
> In file included from drivers/usb/dwc3/gadget.c:18:
> drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’:
> include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function [-Wuninitialized]
>   235 |    printf(pr_fmt(fmt), ##args); \
>       |    ^~~~~~
> drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here
>  1347 |  unsigned long  flags;
>       |                 ^~~~~
>
> and so on...
> Drop useless debug() call to make compiler happy.
>
> Fixes: 0c06db598367 ("lib, linux: move linux specific defines to linux/compat.h")
> Cc: Heiko Schocher <[hidden email]>
> Cc: Tom Rini <[hidden email]>
> Signed-off-by: Andy Shevchenko <[hidden email]>
> Reviewed-by: Oleksandr Andrushchenko <[hidden email]>
> Reviewed-by: Heiko Schocher <[hidden email]>
Applied to u-boot/master, thanks!

--
Tom

signature.asc (673 bytes) Download Attachment