[PATCH] tpm: spi: Cleanup source code

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] tpm: spi: Cleanup source code

Michal Simek-3
There is no need for GD to be used and priv variable is unused.

Signed-off-by: Michal Simek <[hidden email]>
---

 drivers/tpm/tpm2_tis_spi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/tpm/tpm2_tis_spi.c b/drivers/tpm/tpm2_tis_spi.c
index 9a8145e6ba1f..0045bedf0c61 100644
--- a/drivers/tpm/tpm2_tis_spi.c
+++ b/drivers/tpm/tpm2_tis_spi.c
@@ -30,8 +30,6 @@
 #include "tpm_tis.h"
 #include "tpm_internal.h"
 
-DECLARE_GLOBAL_DATA_PTR;
-
 #define TPM_ACCESS(l) (0x0000 | ((l) << 12))
 #define TPM_INT_ENABLE(l)               (0x0008 | ((l) << 12))
 #define TPM_STS(l) (0x0018 | ((l) << 12))
@@ -520,7 +518,6 @@ static int tpm_tis_spi_cleanup(struct udevice *dev)
 static int tpm_tis_spi_open(struct udevice *dev)
 {
  struct tpm_chip *chip = dev_get_priv(dev);
- struct tpm_chip_priv *priv = dev_get_uclass_priv(dev);
 
  if (chip->is_open)
  return -EBUSY;
--
2.29.2

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] tpm: spi: Cleanup source code

Simon Glass-3
On Mon, 9 Nov 2020 at 07:46, Michal Simek <[hidden email]> wrote:
>
> There is no need for GD to be used and priv variable is unused.
>
> Signed-off-by: Michal Simek <[hidden email]>
> ---
>
>  drivers/tpm/tpm2_tis_spi.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Simon Glass <[hidden email]>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] tpm: spi: Cleanup source code

Michal Simek-4
In reply to this post by Michal Simek-3
po 9. 11. 2020 v 15:46 odesílatel Michal Simek <[hidden email]> napsal:

>
> There is no need for GD to be used and priv variable is unused.
>
> Signed-off-by: Michal Simek <[hidden email]>
> ---
>
>  drivers/tpm/tpm2_tis_spi.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/tpm/tpm2_tis_spi.c b/drivers/tpm/tpm2_tis_spi.c
> index 9a8145e6ba1f..0045bedf0c61 100644
> --- a/drivers/tpm/tpm2_tis_spi.c
> +++ b/drivers/tpm/tpm2_tis_spi.c
> @@ -30,8 +30,6 @@
>  #include "tpm_tis.h"
>  #include "tpm_internal.h"
>
> -DECLARE_GLOBAL_DATA_PTR;
> -
>  #define TPM_ACCESS(l)                  (0x0000 | ((l) << 12))
>  #define TPM_INT_ENABLE(l)               (0x0008 | ((l) << 12))
>  #define TPM_STS(l)                     (0x0018 | ((l) << 12))
> @@ -520,7 +518,6 @@ static int tpm_tis_spi_cleanup(struct udevice *dev)
>  static int tpm_tis_spi_open(struct udevice *dev)
>  {
>         struct tpm_chip *chip = dev_get_priv(dev);
> -       struct tpm_chip_priv *priv = dev_get_uclass_priv(dev);
>
>         if (chip->is_open)
>                 return -EBUSY;
> --
> 2.29.2
>

Not sure who should take it but I am taking it via my tree.
M


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs