[PATCH] spl: Avoid printing boot device if silent console is enabled

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] spl: Avoid printing boot device if silent console is enabled

Otavio Salvador
Signed-off-by: Otavio Salvador <[hidden email]>
---

 common/spl/spl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index 4840d1d367..63c48fbf33 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -552,7 +552,9 @@ static int boot_from_devices(struct spl_image_info *spl_image,
  struct spl_image_loader *loader;
 
  loader = spl_ll_find_loader(spl_boot_list[i]);
-#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
+#if defined(CONFIG_SPL_SERIAL_SUPPORT) \
+    && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)    \
+    && !defined(CONFIG_SILENT_CONSOLE)
  if (loader)
  printf("Trying to boot from %s\n", loader->name);
  else
--
2.28.0

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] spl: Avoid printing boot device if silent console is enabled

Tom Rini-4
On Thu, Sep 03, 2020 at 02:25:15PM -0300, Otavio Salvador wrote:

> Signed-off-by: Otavio Salvador <[hidden email]>

Reviewed-by: Tom Rini <[hidden email]>

--
Tom

signature.asc (673 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] spl: Avoid printing boot device if silent console is enabled

Stefan Roese
In reply to this post by Otavio Salvador
On 03.09.20 19:25, Otavio Salvador wrote:

> Signed-off-by: Otavio Salvador <[hidden email]>
> ---
>
>   common/spl/spl.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index 4840d1d367..63c48fbf33 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -552,7 +552,9 @@ static int boot_from_devices(struct spl_image_info *spl_image,
>   struct spl_image_loader *loader;
>  
>   loader = spl_ll_find_loader(spl_boot_list[i]);
> -#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
> +#if defined(CONFIG_SPL_SERIAL_SUPPORT) \
> +    && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)    \
> +    && !defined(CONFIG_SILENT_CONSOLE)

Nitpicking:
I think its preferred to put the "&&" (or "||") at the end of the line.

Other than that:

Reviewed-by: Stefan Roese <[hidden email]>

Thanks,
Stefan
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] spl: Avoid printing boot device if silent console is enabled

Tom Rini-4
In reply to this post by Otavio Salvador
On Thu, Sep 03, 2020 at 02:25:15PM -0300, Otavio Salvador wrote:

> Signed-off-by: Otavio Salvador <[hidden email]>
> Reviewed-by: Tom Rini <[hidden email]>
> Reviewed-by: Stefan Roese <[hidden email]>

Applied to u-boot/master, thanks!

--
Tom

signature.asc (673 bytes) Download Attachment