[PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

Adam Ford
A generic compatibility string was added, but it doesn't match the
name used by Linux or the device tree bindings from any of the SoC's.
Fix it to read "renesas,rcar-gen3-rpc-if"

Fixes: 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2 fallback compatibility string")
Signed-off-by: Adam Ford <[hidden email]>

diff --git a/drivers/spi/renesas_rpc_spi.c b/drivers/spi/renesas_rpc_spi.c
index d0ff918af8..0724a03a34 100644
--- a/drivers/spi/renesas_rpc_spi.c
+++ b/drivers/spi/renesas_rpc_spi.c
@@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
  { .compatible = "renesas,rpc-r8a77965" },
  { .compatible = "renesas,rpc-r8a77970" },
  { .compatible = "renesas,rpc-r8a77995" },
- { .compatible = "renesas,rcar-gen3-rpc" },
+ { .compatible = "renesas,rcar-gen3-rpc-if" },
  { }
 };
 
--
2.25.1

Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

Biju Das
Hi Adam,

Thanks for the patch.

> -----Original Message-----
> From: Adam Ford <[hidden email]>
> Sent: 04 January 2021 17:38
> To: [hidden email]
> Cc: [hidden email]; Biju Das <[hidden email]>;
> Adam Ford <[hidden email]>
> Subject: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string
>
> A generic compatibility string was added, but it doesn't match the name
> used by Linux or the device tree bindings from any of the SoC's.
> Fix it to read "renesas,rcar-gen3-rpc-if"

The framework used in Linux and u-boot are different. On Linux there is Core RPC-IF driver which has the above compatible string, with support for both spi flash and hyperflash support.

Where as in u-boot, it is supporting only rpc spi flash. Since the driver is not supporting hyperflash in u-boot, may be we could reuse "renesas,rcar-gen3-rpc-if" just for rpc spi flash.

Marek, What do you think?

Cheers,
Biju

>
> Fixes: 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2
> fallback compatibility string")
> Signed-off-by: Adam Ford <[hidden email]>
>
> diff --git a/drivers/spi/renesas_rpc_spi.c b/drivers/spi/renesas_rpc_spi.c
> index d0ff918af8..0724a03a34 100644
> --- a/drivers/spi/renesas_rpc_spi.c
> +++ b/drivers/spi/renesas_rpc_spi.c
> @@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
>   { .compatible = "renesas,rpc-r8a77965" },
>   { .compatible = "renesas,rpc-r8a77970" },
>   { .compatible = "renesas,rpc-r8a77995" },
> - { .compatible = "renesas,rcar-gen3-rpc" },
> + { .compatible = "renesas,rcar-gen3-rpc-if" },
>   { }
>  };
>
> --
> 2.25.1

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

Adam Ford
On Tue, Jan 5, 2021 at 6:08 AM Biju Das <[hidden email]> wrote:

>
> Hi Adam,
>
> Thanks for the patch.
>
> > -----Original Message-----
> > From: Adam Ford <[hidden email]>
> > Sent: 04 January 2021 17:38
> > To: [hidden email]
> > Cc: [hidden email]; Biju Das <[hidden email]>;
> > Adam Ford <[hidden email]>
> > Subject: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string
> >
> > A generic compatibility string was added, but it doesn't match the name
> > used by Linux or the device tree bindings from any of the SoC's.
> > Fix it to read "renesas,rcar-gen3-rpc-if"
>
> The framework used in Linux and u-boot are different. On Linux there is Core RPC-IF driver which has the above compatible string, with support for both spi flash and hyperflash support.

Does the hyperflash have a separate .compatible entry?

> Where as in u-boot, it is supporting only rpc spi flash. Since the driver is not supporting hyperflash in u-boot, may be we could reuse "renesas,rcar-gen3-rpc-if" just for rpc spi flash.

It seems like we should make the driver compatible flag match,
otherwise, we'll be needing to add additional -u-boot.dtsi files with
these compatibility flags.

>
> Marek, What do you think?

Gentle nudge.


adam

>
> Cheers,
> Biju
>
> >
> > Fixes: 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2
> > fallback compatibility string")
> > Signed-off-by: Adam Ford <[hidden email]>
> >
> > diff --git a/drivers/spi/renesas_rpc_spi.c b/drivers/spi/renesas_rpc_spi.c
> > index d0ff918af8..0724a03a34 100644
> > --- a/drivers/spi/renesas_rpc_spi.c
> > +++ b/drivers/spi/renesas_rpc_spi.c
> > @@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
> >       { .compatible = "renesas,rpc-r8a77965" },
> >       { .compatible = "renesas,rpc-r8a77970" },
> >       { .compatible = "renesas,rpc-r8a77995" },
> > -     { .compatible = "renesas,rcar-gen3-rpc" },
> > +     { .compatible = "renesas,rcar-gen3-rpc-if" },
> >       { }
> >  };
> >
> > --
> > 2.25.1
>
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

Biju Das
Hi Adam,

Thanks for the reply.

> -----Original Message-----
> Subject: Re: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility
> string
>
> On Tue, Jan 5, 2021 at 6:08 AM Biju Das <[hidden email]>
> wrote:
> >
> > Hi Adam,
> >
> > Thanks for the patch.
> >
> > > -----Original Message-----
> > > From: Adam Ford <[hidden email]>
> > > Sent: 04 January 2021 17:38
> > > To: [hidden email]
> > > Cc: [hidden email]; Biju Das
> > > <[hidden email]>; Adam Ford <[hidden email]>
> > > Subject: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility
> > > string
> > >
> > > A generic compatibility string was added, but it doesn't match the
> > > name used by Linux or the device tree bindings from any of the SoC's.
> > > Fix it to read "renesas,rcar-gen3-rpc-if"
> >
> > The framework used in Linux and u-boot are different. On Linux there is
> Core RPC-IF driver which has the above compatible string, with support for
> both spi flash and hyperflash support.
>
> Does the hyperflash have a separate .compatible entry?

Core driver [1] and documentation[2] is  here
[1]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/memory/renesas-rpc-if.c?h=next-20210113
[2]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml?h=next-20210113

As per [2], hyperflash uses same compatible string and there is no compatible stuff defined in hyperflash driver[3]
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/mtd/hyperbus/rpc-if.c?h=next-20210113

>
> > Where as in u-boot, it is supporting only rpc spi flash. Since the
> driver is not supporting hyperflash in u-boot, may be we could reuse
> "renesas,rcar-gen3-rpc-if" just for rpc spi flash.

Sorry , just found that U-boot have hyperflash support[4] and it uses compatible string "renesas,rpc".
[4] https://elixir.bootlin.com/u-boot/v2021.01-rc5/source/drivers/mtd/renesas_rpc_hf.c

Thanks,
Biju


> >
> > >
> > > Fixes: 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2
> > > fallback compatibility string")
> > > Signed-off-by: Adam Ford <[hidden email]>
> > >
> > > diff --git a/drivers/spi/renesas_rpc_spi.c
> > > b/drivers/spi/renesas_rpc_spi.c index d0ff918af8..0724a03a34 100644
> > > --- a/drivers/spi/renesas_rpc_spi.c
> > > +++ b/drivers/spi/renesas_rpc_spi.c
> > > @@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
> > >       { .compatible = "renesas,rpc-r8a77965" },
> > >       { .compatible = "renesas,rpc-r8a77970" },
> > >       { .compatible = "renesas,rpc-r8a77995" },
> > > -     { .compatible = "renesas,rcar-gen3-rpc" },
> > > +     { .compatible = "renesas,rcar-gen3-rpc-if" },
> > >       { }
> > >  };
> > >
> > > --
> > > 2.25.1
> >