[PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig

Alex Hixon
The config name enabling the rk3399-pinctrl driver is spelled wrong, so
it does not get built. This causes SPL to fail during board init.

Make rk3399-firefly boot by enabling the pinctrl driver via the correct
config name.

Signed-off-by: Alex Hixon <[hidden email]>
---
 configs/firefly-rk3399_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
index f30f131f34..0a4d005975 100644
--- a/configs/firefly-rk3399_defconfig
+++ b/configs/firefly-rk3399_defconfig
@@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
 CONFIG_PINCTRL=y
 CONFIG_SPL_PINCTRL=y
-CONFIG_ROCKCHIP_RK3399_PINCTRL=y
+CONFIG_PINCTRL_ROCKCHIP_RK3399=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_RK8XX=y
 CONFIG_REGULATOR_PWM=y
--
2.11.0

_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig

Tom Rini-4
On Mon, May 15, 2017 at 10:01:32PM +1000, Alex Hixon wrote:

> The config name enabling the rk3399-pinctrl driver is spelled wrong, so
> it does not get built. This causes SPL to fail during board init.
>
> Make rk3399-firefly boot by enabling the pinctrl driver via the correct
> config name.
>
> Signed-off-by: Alex Hixon <[hidden email]>
> ---
>  configs/firefly-rk3399_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
> index f30f131f34..0a4d005975 100644
> --- a/configs/firefly-rk3399_defconfig
> +++ b/configs/firefly-rk3399_defconfig
> @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y
>  CONFIG_GMAC_ROCKCHIP=y
>  CONFIG_PINCTRL=y
>  CONFIG_SPL_PINCTRL=y
> -CONFIG_ROCKCHIP_RK3399_PINCTRL=y
> +CONFIG_PINCTRL_ROCKCHIP_RK3399=y
>  CONFIG_DM_PMIC=y
>  CONFIG_PMIC_RK8XX=y
>  CONFIG_REGULATOR_PWM=y
Shouldn't the RK3399 pinctrl driver at least by default y?  Or imply'd ?

--
Tom

_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig

Mark Kettenis-2
In reply to this post by Alex Hixon
> From: Alex Hixon <[hidden email]>
> Date: Mon, 15 May 2017 22:01:32 +1000
>
> The config name enabling the rk3399-pinctrl driver is spelled wrong, so
> it does not get built. This causes SPL to fail during board init.
>
> Make rk3399-firefly boot by enabling the pinctrl driver via the correct
> config name.
>
> Signed-off-by: Alex Hixon <[hidden email]>

Reviewed-by: Mark Kettenis <[hidden email]>

> ---
>  configs/firefly-rk3399_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
> index f30f131f34..0a4d005975 100644
> --- a/configs/firefly-rk3399_defconfig
> +++ b/configs/firefly-rk3399_defconfig
> @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y
>  CONFIG_GMAC_ROCKCHIP=y
>  CONFIG_PINCTRL=y
>  CONFIG_SPL_PINCTRL=y
> -CONFIG_ROCKCHIP_RK3399_PINCTRL=y
> +CONFIG_PINCTRL_ROCKCHIP_RK3399=y
>  CONFIG_DM_PMIC=y
>  CONFIG_PMIC_RK8XX=y
>  CONFIG_REGULATOR_PWM=y
> --
> 2.11.0
>
> _______________________________________________
> U-Boot mailing list
> [hidden email]
> https://lists.denx.de/listinfo/u-boot
>
>
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig

Simon Glass-3
In reply to this post by Tom Rini-4
On 15 May 2017 at 06:30, Tom Rini <[hidden email]> wrote:

> On Mon, May 15, 2017 at 10:01:32PM +1000, Alex Hixon wrote:
>
>> The config name enabling the rk3399-pinctrl driver is spelled wrong, so
>> it does not get built. This causes SPL to fail during board init.
>>
>> Make rk3399-firefly boot by enabling the pinctrl driver via the correct
>> config name.
>>
>> Signed-off-by: Alex Hixon <[hidden email]>
>> ---
>>  configs/firefly-rk3399_defconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
>> index f30f131f34..0a4d005975 100644
>> --- a/configs/firefly-rk3399_defconfig
>> +++ b/configs/firefly-rk3399_defconfig
>> @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y
>>  CONFIG_GMAC_ROCKCHIP=y
>>  CONFIG_PINCTRL=y
>>  CONFIG_SPL_PINCTRL=y
>> -CONFIG_ROCKCHIP_RK3399_PINCTRL=y
>> +CONFIG_PINCTRL_ROCKCHIP_RK3399=y
>>  CONFIG_DM_PMIC=y
>>  CONFIG_PMIC_RK8XX=y
>>  CONFIG_REGULATOR_PWM=y
>
> Shouldn't the RK3399 pinctrl driver at least by default y?  Or imply'd ?

Yes that sounds good!

Reviewed-by: Simon Glass <[hidden email]>
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig

Kever Yang
In reply to this post by Alex Hixon
Hi Alex,


Thanks for your patch, but this patch is just the same with the one from
Heiko[0], right?


Thanks,

- Kever

[0] https://patchwork.ozlabs.org/patch/758272/


On 05/15/2017 08:01 PM, Alex Hixon wrote:

> The config name enabling the rk3399-pinctrl driver is spelled wrong, so
> it does not get built. This causes SPL to fail during board init.
>
> Make rk3399-firefly boot by enabling the pinctrl driver via the correct
> config name.
>
> Signed-off-by: Alex Hixon <[hidden email]>
> ---
>   configs/firefly-rk3399_defconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
> index f30f131f34..0a4d005975 100644
> --- a/configs/firefly-rk3399_defconfig
> +++ b/configs/firefly-rk3399_defconfig
> @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y
>   CONFIG_GMAC_ROCKCHIP=y
>   CONFIG_PINCTRL=y
>   CONFIG_SPL_PINCTRL=y
> -CONFIG_ROCKCHIP_RK3399_PINCTRL=y
> +CONFIG_PINCTRL_ROCKCHIP_RK3399=y
>   CONFIG_DM_PMIC=y
>   CONFIG_PMIC_RK8XX=y
>   CONFIG_REGULATOR_PWM=y


_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] rockchip: firefly-rk3399: enable rk3399 pinctrl in defconfig

Alex Hixon
Hi Kever,

Ahh, yup! You're totally right! I didn't see Heiko's patch earlier.

My mistake.

Cheers,
Alex

On 18 May 2017 12:38 PM, "Kever Yang" <[hidden email]> wrote:

> Hi Alex,
>
>
> Thanks for your patch, but this patch is just the same with the one from
> Heiko[0], right?
>
>
> Thanks,
>
> - Kever
>
> [0] https://patchwork.ozlabs.org/patch/758272/
>
>
> On 05/15/2017 08:01 PM, Alex Hixon wrote:
>
>> The config name enabling the rk3399-pinctrl driver is spelled wrong, so
>> it does not get built. This causes SPL to fail during board init.
>>
>> Make rk3399-firefly boot by enabling the pinctrl driver via the correct
>> config name.
>>
>> Signed-off-by: Alex Hixon <[hidden email]>
>> ---
>>   configs/firefly-rk3399_defconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configs/firefly-rk3399_defconfig
>> b/configs/firefly-rk3399_defconfig
>> index f30f131f34..0a4d005975 100644
>> --- a/configs/firefly-rk3399_defconfig
>> +++ b/configs/firefly-rk3399_defconfig
>> @@ -39,7 +39,7 @@ CONFIG_ETH_DESIGNWARE=y
>>   CONFIG_GMAC_ROCKCHIP=y
>>   CONFIG_PINCTRL=y
>>   CONFIG_SPL_PINCTRL=y
>> -CONFIG_ROCKCHIP_RK3399_PINCTRL=y
>> +CONFIG_PINCTRL_ROCKCHIP_RK3399=y
>>   CONFIG_DM_PMIC=y
>>   CONFIG_PMIC_RK8XX=y
>>   CONFIG_REGULATOR_PWM=y
>>
>
>
>
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot