[PATCH] rockchip: Enable BINMAN for boards enable SPL_OPTEE

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] rockchip: Enable BINMAN for boards enable SPL_OPTEE

Kever Yang
Rockchip has many 32bit SoCs and some of them are support SPL_OPTEE now,
only boards with SPL_OPTEE support can fit BINMAN well, other boards
will fail at initr_binman() in U-Boot proper after below patch,
eg. rv1108 board.
    83187546ae binman: Support multiple images in the library

Fixes: 79030a4861 ("rockchip: Add Single boot image (with binman, pad_cat)")
Signed-off-by: Kever Yang <[hidden email]>
---

 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index b2f7fcbd6e..5903c09370 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1721,7 +1721,7 @@ config ARCH_STM32MP
 config ARCH_ROCKCHIP
  bool "Support Rockchip SoCs"
  select BLK
- select BINMAN if !ARM64
+ select BINMAN if SPL_OPTEE
  select DM
  select DM_GPIO
  select DM_I2C
--
2.25.1



Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] rockchip: Enable BINMAN for boards enable SPL_OPTEE

Simon Glass-3
Hi Kever,

On Mon, 9 Nov 2020 at 20:43, Kever Yang <[hidden email]> wrote:
>
> Rockchip has many 32bit SoCs and some of them are support SPL_OPTEE now,
> only boards with SPL_OPTEE support can fit BINMAN well, other boards
> will fail at initr_binman() in U-Boot proper after below patch,
> eg. rv1108 board.
>     83187546ae binman: Support multiple images in the library

Is the problem that binman_init() adds too much code? If so, we could
have a new BINMAN_RUNTIME option that enables binman.c and thus allow
boards to disable it.

I imagine that most boards will end up using binman, but many will not
need to access the image definition at runtime.

>
> Fixes: 79030a4861 ("rockchip: Add Single boot image (with binman, pad_cat)")
> Signed-off-by: Kever Yang <[hidden email]>
> ---
>
>  arch/arm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index b2f7fcbd6e..5903c09370 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1721,7 +1721,7 @@ config ARCH_STM32MP
>  config ARCH_ROCKCHIP
>         bool "Support Rockchip SoCs"
>         select BLK
> -       select BINMAN if !ARM64
> +       select BINMAN if SPL_OPTEE
>         select DM
>         select DM_GPIO
>         select DM_I2C
> --
> 2.25.1
>
>
>

Regards,
Simon