[PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL

Nishanth Menon-2
power/regulator will not be built if just CONFIG_SPL_DM_REGULATOR is
enabled. It needs CONFIG_SPL_POWER_SUPPORT to be enabled as well.

For example, if we just need a GPIO regulator in SPL:
CONFIG_DM_REGULATOR=y
CONFIG_SPL_DM_REGULATOR=y
CONFIG_DM_REGULATOR_GPIO=y
CONFIG_SPL_DM_REGULATOR_GPIO=y

Will not suffice, since the entire regulator build for SPL depends on
CONFIG_SPL_POWER_SUPPORT. Elaborate that information in the Kconfig
dependency.

Signed-off-by: Nishanth Menon <[hidden email]>
---
 drivers/power/regulator/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig
index d431102462a8..fbbea18c7d1b 100644
--- a/drivers/power/regulator/Kconfig
+++ b/drivers/power/regulator/Kconfig
@@ -18,7 +18,7 @@ config DM_REGULATOR
 
 config SPL_DM_REGULATOR
  bool "Enable regulators for SPL"
- depends on DM_REGULATOR
+ depends on DM_REGULATOR && SPL_POWER_SUPPORT
  ---help---
  Regulators are seldom needed in SPL. Even if they are accessed, some
  code space can be saved by accessing the PMIC registers directly.
--
2.25.1.377.g2d2118b814c1

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL

Jaehoon Chung
On 11/20/20 1:10 PM, Nishanth Menon wrote:

> power/regulator will not be built if just CONFIG_SPL_DM_REGULATOR is
> enabled. It needs CONFIG_SPL_POWER_SUPPORT to be enabled as well.
>
> For example, if we just need a GPIO regulator in SPL:
> CONFIG_DM_REGULATOR=y
> CONFIG_SPL_DM_REGULATOR=y
> CONFIG_DM_REGULATOR_GPIO=y
> CONFIG_SPL_DM_REGULATOR_GPIO=y
>
> Will not suffice, since the entire regulator build for SPL depends on
> CONFIG_SPL_POWER_SUPPORT. Elaborate that information in the Kconfig
> dependency.
>
> Signed-off-by: Nishanth Menon <[hidden email]>

Reviewed-by: Jaehoon Chung <[hidden email]>

Best Regards,
Jaehoon Chung

> ---
>  drivers/power/regulator/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig
> index d431102462a8..fbbea18c7d1b 100644
> --- a/drivers/power/regulator/Kconfig
> +++ b/drivers/power/regulator/Kconfig
> @@ -18,7 +18,7 @@ config DM_REGULATOR
>  
>  config SPL_DM_REGULATOR
>   bool "Enable regulators for SPL"
> - depends on DM_REGULATOR
> + depends on DM_REGULATOR && SPL_POWER_SUPPORT
>   ---help---
>   Regulators are seldom needed in SPL. Even if they are accessed, some
>   code space can be saved by accessing the PMIC registers directly.
>