[PATCH] net: ravb: Remove writeext function call

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] net: ravb: Remove writeext function call

Biju Das
The micrel phy driver is already configuring this values from
device tree. So remove the redundant phy configuration call from
this driver.

Signed-off-by: Biju Das <[hidden email]>
Reviewed-by: Lad Prabhakar <[hidden email]>
---
Tested on RCar M3N board, the final configuration value is same.
rxc-skew-ps 19
ksz90x1_of_config_group Final:1f9
---
 drivers/net/ravb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c
index 886f53ee82..98883cd15b 100644
--- a/drivers/net/ravb.c
+++ b/drivers/net/ravb.c
@@ -438,8 +438,6 @@ static int ravb_config(struct udevice *dev)
 
  writel(mask, eth->iobase + RAVB_REG_ECMR);
 
- phy->drv->writeext(phy, -1, 0x02, 0x08, (0x0f << 5) | 0x19);
-
  return 0;
 }
 
--
2.17.1

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] net: ravb: Remove writeext function call

Marek Vasut
On 9/22/20 8:51 AM, Biju Das wrote:
> The micrel phy driver is already configuring this values from
> device tree. So remove the redundant phy configuration call from
> this driver.

Applied to sh/next, thanks