[PATCH] net: eth-uclass: Change uclass driver name to ethernet

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] net: eth-uclass: Change uclass driver name to ethernet

David Wu
dev_read_alias_seq() used uc_drv->name compared to alias
stem string, Ethernet's alias stem uses "ethernet", which
does not match the eth-uclass driver name "eth", can not
get the correct index of ethernet alias namer. So it seems
change uclass driver name to match the alias stem is a more
reasonable way.

Signed-off-by: David Wu <[hidden email]>
---
 net/eth-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index e14695c0f1..7dd962db64 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -594,7 +594,7 @@ static int eth_pre_remove(struct udevice *dev)
 }
 
 UCLASS_DRIVER(eth) = {
- .name = "eth",
+ .name = "ethernet",
  .id = UCLASS_ETH,
  .post_bind = eth_post_bind,
  .pre_unbind = eth_pre_unbind,
--
2.19.1



Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] net: eth-uclass: Change uclass driver name to ethernet

Simon Glass-3
Hi David,

On Wed, 6 Jan 2021 at 20:56, David Wu <[hidden email]> wrote:

>
> dev_read_alias_seq() used uc_drv->name compared to alias
> stem string, Ethernet's alias stem uses "ethernet", which
> does not match the eth-uclass driver name "eth", can not
> get the correct index of ethernet alias namer. So it seems
> change uclass driver name to match the alias stem is a more
> reasonable way.
>
> Signed-off-by: David Wu <[hidden email]>
> ---
>  net/eth-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/eth-uclass.c b/net/eth-uclass.c
> index e14695c0f1..7dd962db64 100644
> --- a/net/eth-uclass.c
> +++ b/net/eth-uclass.c
> @@ -594,7 +594,7 @@ static int eth_pre_remove(struct udevice *dev)
>  }
>
>  UCLASS_DRIVER(eth) = {

Should change this one too ^

> -       .name           = "eth",
> +       .name           = "ethernet",
>         .id             = UCLASS_ETH,
>         .post_bind      = eth_post_bind,
>         .pre_unbind     = eth_pre_unbind,
> --
> 2.19.1
>
>

Regards,
Simon

>