[PATCH] mmc: display an error number to debug

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] mmc: display an error number to debug

Jaehoon Chung
It's useful to know an error number when it's debugging.

Signed-off-by: Jaehoon Chung <[hidden email]>
---
 drivers/mmc/mmc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 7783535d0953..2457c6fef97a 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -2179,7 +2179,7 @@ static int mmc_select_mode_and_width(struct mmc *mmc, uint card_caps)
  err = mmc_execute_tuning(mmc,
  mwt->tuning);
  if (err) {
- pr_debug("tuning failed\n");
+ pr_debug("tuning failed : %d\n", err);
  goto error;
  }
  }
@@ -2200,7 +2200,7 @@ error:
  }
  }
 
- pr_err("unable to select a mode\n");
+ pr_err("unable to select a mode : %d\n", err);
 
  return -ENOTSUPP;
 }
@@ -2746,7 +2746,7 @@ static int mmc_power_on(struct mmc *mmc)
  int ret = regulator_set_enable(mmc->vmmc_supply, true);
 
  if (ret) {
- puts("Error enabling VMMC supply\n");
+ puts("Error enabling VMMC supply : %d\n", ret);
  return ret;
  }
  }
@@ -2762,7 +2762,7 @@ static int mmc_power_off(struct mmc *mmc)
  int ret = regulator_set_enable(mmc->vmmc_supply, false);
 
  if (ret) {
- pr_debug("Error disabling VMMC supply\n");
+ pr_debug("Error disabling VMMC supply : %d\n", ret);
  return ret;
  }
  }
@@ -2866,7 +2866,7 @@ retry:
 
  if (err) {
 #if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
- pr_err("Card did not respond to voltage select!\n");
+ pr_err("Card did not respond to voltage select! : %d\n", err);
 #endif
  return -EOPNOTSUPP;
  }
--
2.29.0

Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] mmc: display an error number to debug

Peng Fan-4
> Subject: [PATCH] mmc: display an error number to debug
>
> It's useful to know an error number when it's debugging.
>
> Signed-off-by: Jaehoon Chung <[hidden email]>
> ---
>  drivers/mmc/mmc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index
> 7783535d0953..2457c6fef97a 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2179,7 +2179,7 @@ static int mmc_select_mode_and_width(struct
> mmc *mmc, uint card_caps)
>   err = mmc_execute_tuning(mmc,
>   mwt->tuning);
>   if (err) {
> - pr_debug("tuning failed\n");
> + pr_debug("tuning failed : %d\n", err);
>   goto error;
>   }
>   }
> @@ -2200,7 +2200,7 @@ error:
>   }
>   }
>
> - pr_err("unable to select a mode\n");
> + pr_err("unable to select a mode : %d\n", err);
>
>   return -ENOTSUPP;
>  }
> @@ -2746,7 +2746,7 @@ static int mmc_power_on(struct mmc *mmc)
>   int ret = regulator_set_enable(mmc->vmmc_supply, true);
>
>   if (ret) {
> - puts("Error enabling VMMC supply\n");
> + puts("Error enabling VMMC supply : %d\n", ret);
>   return ret;
>   }
>   }
> @@ -2762,7 +2762,7 @@ static int mmc_power_off(struct mmc *mmc)
>   int ret = regulator_set_enable(mmc->vmmc_supply, false);
>
>   if (ret) {
> - pr_debug("Error disabling VMMC supply\n");
> + pr_debug("Error disabling VMMC supply : %d\n", ret);
>   return ret;
>   }
>   }
> @@ -2866,7 +2866,7 @@ retry:
>
>   if (err) {
>  #if !defined(CONFIG_SPL_BUILD) ||
> defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
> - pr_err("Card did not respond to voltage select!\n");
> + pr_err("Card did not respond to voltage select! : %d\n", err);
>  #endif
>   return -EOPNOTSUPP;
>   }
> --

Reviewed-by: Peng Fan <[hidden email]>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] mmc: display an error number to debug

Stephen Warren-2
In reply to this post by Jaehoon Chung
On 11/6/20 4:23 AM, Jaehoon Chung wrote:
> It's useful to know an error number when it's debugging.

> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c

> @@ -2746,7 +2746,7 @@ static int mmc_power_on(struct mmc *mmc)
>   int ret = regulator_set_enable(mmc->vmmc_supply, true);
>  
>   if (ret) {
> - puts("Error enabling VMMC supply\n");
> + puts("Error enabling VMMC supply : %d\n", ret);

At least this one needs to be printf() not puts(). This causes build
failures for any board that compiles this code, i.e. anything with the
following enabled:

static int mmc_power_on(struct mmc *mmc)
{
#if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_REGULATOR)
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] mmc: display an error number to debug

Jaehoon Chung
Dear Stephen,

On 11/17/20 12:39 AM, Stephen Warren wrote:

> On 11/6/20 4:23 AM, Jaehoon Chung wrote:
>> It's useful to know an error number when it's debugging.
>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>
>> @@ -2746,7 +2746,7 @@ static int mmc_power_on(struct mmc *mmc)
>>   int ret = regulator_set_enable(mmc->vmmc_supply, true);
>>  
>>   if (ret) {
>> - puts("Error enabling VMMC supply\n");
>> + puts("Error enabling VMMC supply : %d\n", ret);
>
> At least this one needs to be printf() not puts(). This causes build
> failures for any board that compiles this code, i.e. anything with the
> following enabled:

Thanks for pointing out! Will fix.

Best Regards,
Jaehoon Chung

>
> static int mmc_power_on(struct mmc *mmc)
> {
> #if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_REGULATOR)
>