[PATCH] imx: ventana: Rework CONFIG_CMD_GSC code to not be included in SPL

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] imx: ventana: Rework CONFIG_CMD_GSC code to not be included in SPL

Tom Rini-4
The command can only be used from full U-Boot, so do not build it into
SPL.

Cc: Stefano Babic <[hidden email]>
Cc: Fabio Estevam <[hidden email]>
Cc: Tim Harvey <[hidden email]>
Signed-off-by: Tom Rini <[hidden email]>
---
 board/gateworks/gw_ventana/gsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/gateworks/gw_ventana/gsc.c b/board/gateworks/gw_ventana/gsc.c
index 68b1ddb532e0..f2a01b84deb2 100644
--- a/board/gateworks/gw_ventana/gsc.c
+++ b/board/gateworks/gw_ventana/gsc.c
@@ -172,7 +172,7 @@ int gsc_boot_wd_disable(void)
  return 1;
 }
 
-#ifdef CONFIG_CMD_GSC
+#if defined(CONFIG_CMD_GSC) && !defined(CONFIG_SPL_BUILD)
 static int do_gsc_sleep(cmd_tbl_t *cmdtp, int flag, int argc,
  char * const argv[])
 {
--
2.7.4

_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] imx: ventana: Rework CONFIG_CMD_GSC code to not be included in SPL

Tim Harvey
On Wed, Jan 3, 2018 at 6:16 AM, Tom Rini <[hidden email]> wrote:

> The command can only be used from full U-Boot, so do not build it into
> SPL.
>
> Cc: Stefano Babic <[hidden email]>
> Cc: Fabio Estevam <[hidden email]>
> Cc: Tim Harvey <[hidden email]>
> Signed-off-by: Tom Rini <[hidden email]>
> ---
>  board/gateworks/gw_ventana/gsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/gateworks/gw_ventana/gsc.c b/board/gateworks/gw_ventana/gsc.c
> index 68b1ddb532e0..f2a01b84deb2 100644
> --- a/board/gateworks/gw_ventana/gsc.c
> +++ b/board/gateworks/gw_ventana/gsc.c
> @@ -172,7 +172,7 @@ int gsc_boot_wd_disable(void)
>         return 1;
>  }
>
> -#ifdef CONFIG_CMD_GSC
> +#if defined(CONFIG_CMD_GSC) && !defined(CONFIG_SPL_BUILD)
>  static int do_gsc_sleep(cmd_tbl_t *cmdtp, int flag, int argc,
>                         char * const argv[])
>  {
> --
> 2.7.4
>

Acked-by: Tim Harvey <[hidden email]>

Thanks Tom,

Tim
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] imx: ventana: Rework CONFIG_CMD_GSC code to not be included in SPL

Fabio Estevam-2
In reply to this post by Tom Rini-4
On Wed, Jan 3, 2018 at 12:16 PM, Tom Rini <[hidden email]> wrote:
> The command can only be used from full U-Boot, so do not build it into
> SPL.
>
> Cc: Stefano Babic <[hidden email]>
> Cc: Fabio Estevam <[hidden email]>
> Cc: Tim Harvey <[hidden email]>
> Signed-off-by: Tom Rini <[hidden email]>

Reviewed-by: Fabio Estevam <[hidden email]>
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] imx: ventana: Rework CONFIG_CMD_GSC code to not be included in SPL

Stefano Babic
In reply to this post by Tom Rini-4
On 03/01/2018 15:16, Tom Rini wrote:

> The command can only be used from full U-Boot, so do not build it into
> SPL.
>
> Cc: Stefano Babic <[hidden email]>
> Cc: Fabio Estevam <[hidden email]>
> Cc: Tim Harvey <[hidden email]>
> Signed-off-by: Tom Rini <[hidden email]>
> ---
>  board/gateworks/gw_ventana/gsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/gateworks/gw_ventana/gsc.c b/board/gateworks/gw_ventana/gsc.c
> index 68b1ddb532e0..f2a01b84deb2 100644
> --- a/board/gateworks/gw_ventana/gsc.c
> +++ b/board/gateworks/gw_ventana/gsc.c
> @@ -172,7 +172,7 @@ int gsc_boot_wd_disable(void)
>   return 1;
>  }
>  
> -#ifdef CONFIG_CMD_GSC
> +#if defined(CONFIG_CMD_GSC) && !defined(CONFIG_SPL_BUILD)
>  static int do_gsc_sleep(cmd_tbl_t *cmdtp, int flag, int argc,
>   char * const argv[])
>  {
>
Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


--
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [hidden email]
=====================================================================
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot