[PATCH] imx: ventana: Rework CONFIG_CMD_EECONFIG code to not be included in SPL

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] imx: ventana: Rework CONFIG_CMD_EECONFIG code to not be included in SPL

Tom Rini-4
The command can only be used from full U-Boot, so do not build it into
SPL.

Cc: Stefano Babic <[hidden email]>
Cc: Fabio Estevam <[hidden email]>
Cc: Tim Harvey <[hidden email]>
Signed-off-by: Tom Rini <[hidden email]>
---
 board/gateworks/gw_ventana/eeprom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/gateworks/gw_ventana/eeprom.c b/board/gateworks/gw_ventana/eeprom.c
index 2c07a84fffcb..a435dd9fb7b7 100644
--- a/board/gateworks/gw_ventana/eeprom.c
+++ b/board/gateworks/gw_ventana/eeprom.c
@@ -119,7 +119,7 @@ struct ventana_eeprom_config econfig[] = {
  { /* Sentinel */ }
 };
 
-#ifdef CONFIG_CMD_EECONFIG
+#if defined(CONFIG_CMD_EECONFIG) && !defined(CONFIG_SPL_BUILD)
 static struct ventana_eeprom_config *get_config(const char *name)
 {
  struct ventana_eeprom_config *cfg = econfig;
@@ -135,7 +135,7 @@ static struct ventana_eeprom_config *get_config(const char *name)
 static u8 econfig_bytes[sizeof(ventana_info.config)];
 static int econfig_init = -1;
 
-int do_econfig(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+static int do_econfig(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
  struct ventana_eeprom_config *cfg;
  struct ventana_board_info *info = &ventana_info;
--
2.7.4

_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] imx: ventana: Rework CONFIG_CMD_EECONFIG code to not be included in SPL

Tim Harvey
On Wed, Jan 3, 2018 at 6:15 AM, Tom Rini <[hidden email]> wrote:

> The command can only be used from full U-Boot, so do not build it into
> SPL.
>
> Cc: Stefano Babic <[hidden email]>
> Cc: Fabio Estevam <[hidden email]>
> Cc: Tim Harvey <[hidden email]>
> Signed-off-by: Tom Rini <[hidden email]>
> ---
>  board/gateworks/gw_ventana/eeprom.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/gateworks/gw_ventana/eeprom.c b/board/gateworks/gw_ventana/eeprom.c
> index 2c07a84fffcb..a435dd9fb7b7 100644
> --- a/board/gateworks/gw_ventana/eeprom.c
> +++ b/board/gateworks/gw_ventana/eeprom.c
> @@ -119,7 +119,7 @@ struct ventana_eeprom_config econfig[] = {
>         { /* Sentinel */ }
>  };
>
> -#ifdef CONFIG_CMD_EECONFIG
> +#if defined(CONFIG_CMD_EECONFIG) && !defined(CONFIG_SPL_BUILD)
>  static struct ventana_eeprom_config *get_config(const char *name)
>  {
>         struct ventana_eeprom_config *cfg = econfig;
> @@ -135,7 +135,7 @@ static struct ventana_eeprom_config *get_config(const char *name)
>  static u8 econfig_bytes[sizeof(ventana_info.config)];
>  static int econfig_init = -1;
>
> -int do_econfig(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +static int do_econfig(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  {
>         struct ventana_eeprom_config *cfg;
>         struct ventana_board_info *info = &ventana_info;
> --
> 2.7.4
>

Acked-by: Tim Harvey <[hidden email]>

Thanks Tom,

Tim
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] imx: ventana: Rework CONFIG_CMD_EECONFIG code to not be included in SPL

Fabio Estevam-2
In reply to this post by Tom Rini-4
On Wed, Jan 3, 2018 at 12:15 PM, Tom Rini <[hidden email]> wrote:
> The command can only be used from full U-Boot, so do not build it into
> SPL.
>
> Cc: Stefano Babic <[hidden email]>
> Cc: Fabio Estevam <[hidden email]>
> Cc: Tim Harvey <[hidden email]>
> Signed-off-by: Tom Rini <[hidden email]>

Reviewed-by: Fabio Estevam <[hidden email]>
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] imx: ventana: Rework CONFIG_CMD_EECONFIG code to not be included in SPL

Stefano Babic
In reply to this post by Tom Rini-4
On 03/01/2018 15:15, Tom Rini wrote:

> The command can only be used from full U-Boot, so do not build it into
> SPL.
>
> Cc: Stefano Babic <[hidden email]>
> Cc: Fabio Estevam <[hidden email]>
> Cc: Tim Harvey <[hidden email]>
> Signed-off-by: Tom Rini <[hidden email]>
> ---
>  board/gateworks/gw_ventana/eeprom.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/gateworks/gw_ventana/eeprom.c b/board/gateworks/gw_ventana/eeprom.c
> index 2c07a84fffcb..a435dd9fb7b7 100644
> --- a/board/gateworks/gw_ventana/eeprom.c
> +++ b/board/gateworks/gw_ventana/eeprom.c
> @@ -119,7 +119,7 @@ struct ventana_eeprom_config econfig[] = {
>   { /* Sentinel */ }
>  };
>  
> -#ifdef CONFIG_CMD_EECONFIG
> +#if defined(CONFIG_CMD_EECONFIG) && !defined(CONFIG_SPL_BUILD)
>  static struct ventana_eeprom_config *get_config(const char *name)
>  {
>   struct ventana_eeprom_config *cfg = econfig;
> @@ -135,7 +135,7 @@ static struct ventana_eeprom_config *get_config(const char *name)
>  static u8 econfig_bytes[sizeof(ventana_info.config)];
>  static int econfig_init = -1;
>  
> -int do_econfig(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +static int do_econfig(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  {
>   struct ventana_eeprom_config *cfg;
>   struct ventana_board_info *info = &ventana_info;
>
Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


--
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [hidden email]
=====================================================================
_______________________________________________
U-Boot mailing list
[hidden email]
https://lists.denx.de/listinfo/u-boot