[PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage

Peng Fan (OSS)
From: Peng Fan <[hidden email]>

Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage

Signed-off-by: Peng Fan <[hidden email]>
---

This is to replace
https://patchwork.ozlabs.org/project/uboot/patch/20210103101144.4375-12-peng.fan@.../

 include/configs/imx8mn_evk.h | 2 --
 include/configs/imx8mp_evk.h | 2 --
 2 files changed, 4 deletions(-)

diff --git a/include/configs/imx8mn_evk.h b/include/configs/imx8mn_evk.h
index 92f435f578..369aa538bf 100644
--- a/include/configs/imx8mn_evk.h
+++ b/include/configs/imx8mn_evk.h
@@ -25,8 +25,6 @@
 #define CONFIG_SPL_BSS_MAX_SIZE SZ_8K /* 8 KB */
 #define CONFIG_SYS_SPL_MALLOC_START 0x42200000
 #define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K /* 512 KB */
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
 
 /* For RAW image gives a error info not panic */
 #define CONFIG_SPL_ABORT_ON_RAW_IMAGE
diff --git a/include/configs/imx8mp_evk.h b/include/configs/imx8mp_evk.h
index 7abaf5ff84..f89950f74e 100644
--- a/include/configs/imx8mp_evk.h
+++ b/include/configs/imx8mp_evk.h
@@ -26,8 +26,6 @@
 #define CONFIG_SPL_BSS_MAX_SIZE 0x400 /* 1 KB */
 #define CONFIG_SYS_SPL_MALLOC_START 0x42200000
 #define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K /* 512 KB */
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
 
 #define CONFIG_SPL_ABORT_ON_RAW_IMAGE
 
--
2.28.0

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I, D]CACHE_OFF in SPL stage

Fabio Estevam-2
Hi Peng,

On Tue, Jan 12, 2021 at 11:29 PM Peng Fan (OSS) <[hidden email]> wrote:
>
> From: Peng Fan <[hidden email]>
>
> Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage

These options do not apply to SPL. The CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF do.

I agree with the change, but I think you need:

- Remove SPL from the Subject and commit log.
- Add a phrase saying that it is safe to run with caches enabled on
these platforms.
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage

Peng Fan-4
> Subject: Re: [PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in
> SPL stage
>
> Hi Peng,
>
> On Tue, Jan 12, 2021 at 11:29 PM Peng Fan (OSS) <[hidden email]>
> wrote:
> >
> > From: Peng Fan <[hidden email]>
> >
> > Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage
>
> These options do not apply to SPL. The CONFIG_SPL_SYS_ICACHE_OFF and
> CONFIG_SPL_SYS_DCACHE_OFF do.
>
> I agree with the change, but I think you need:
>
> - Remove SPL from the Subject and commit log.
> - Add a phrase saying that it is safe to run with caches enabled on these
> platforms.

Sure. Thanks.

-Peng.