[PATCH] fs: fat: directory entries starting with 0x05

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] fs: fat: directory entries starting with 0x05

Heinrich Schuchardt
0x05 is used as replacement letter for 0xe5 at the first position of short
file names. We must not skip over directory entries starting with 0x05.

Cf. Microsoft FAT Specification, August 30 2005

Fixes: 39606d462c97 ("fs: fat: handle deleted directory entries correctly")
Signed-off-by: Heinrich Schuchardt <[hidden email]>
---
 fs/fat/fat.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index 28aa5aaa9f..fb6ba89466 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -926,8 +926,7 @@ static int fat_itr_next(fat_itr *itr)
  if (!dent)
  return 0;

- if (dent->name[0] == DELETED_FLAG ||
-    dent->name[0] == aRING)
+ if (dent->name[0] == DELETED_FLAG)
  continue;

  if (dent->attr & ATTR_VOLUME) {
--
2.29.2

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fs: fat: directory entries starting with 0x05

Simon Glass-3
On Sat, 21 Nov 2020 at 05:22, Heinrich Schuchardt <[hidden email]> wrote:

>
> 0x05 is used as replacement letter for 0xe5 at the first position of short
> file names. We must not skip over directory entries starting with 0x05.
>
> Cf. Microsoft FAT Specification, August 30 2005
>
> Fixes: 39606d462c97 ("fs: fat: handle deleted directory entries correctly")
> Signed-off-by: Heinrich Schuchardt <[hidden email]>
> ---
>  fs/fat/fat.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Simon Glass <[hidden email]>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fs: fat: directory entries starting with 0x05

Christian Gmeiner
In reply to this post by Heinrich Schuchardt
Am Sa., 21. Nov. 2020 um 13:22 Uhr schrieb Heinrich Schuchardt
<[hidden email]>:
>
> 0x05 is used as replacement letter for 0xe5 at the first position of short
> file names. We must not skip over directory entries starting with 0x05.
>
> Cf. Microsoft FAT Specification, August 30 2005
>
> Fixes: 39606d462c97 ("fs: fat: handle deleted directory entries correctly")
> Signed-off-by: Heinrich Schuchardt <[hidden email]>

Reviewed-by: Christian Gmeiner <[hidden email]>