[PATCH] dfu: simplify the dependencies of DFU_TFTP

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] dfu: simplify the dependencies of DFU_TFTP

AKASHI Takahiro
Since CONFIG_UPDATE_COMMON always selects CONFIG_DFU_WRITE_ALT, we can
drop the latter from dependencies of CONFIG_DFU_TFTP.

Fixes: 3149e524fc1e ("common: update: add a generic interface for FIT
       image")
Signed-off-by: AKASHI Takahiro <[hidden email]>
---
 drivers/dfu/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
index b7427fc4f0d6..121dc54f5463 100644
--- a/drivers/dfu/Kconfig
+++ b/drivers/dfu/Kconfig
@@ -20,9 +20,8 @@ config DFU_WRITE_ALT
 
 config DFU_TFTP
  bool "DFU via TFTP"
- select DFU_WRITE_ALT
- select DFU_OVER_TFTP
  select UPDATE_COMMON
+ select DFU_OVER_TFTP
  help
   This option allows performing update of DFU-managed medium with data
   sent via TFTP boot.
--
2.28.0

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] dfu: simplify the dependencies of DFU_TFTP

Heinrich Schuchardt
On 17.11.20 01:27, AKASHI Takahiro wrote:
> Since CONFIG_UPDATE_COMMON always selects CONFIG_DFU_WRITE_ALT, we can
> drop the latter from dependencies of CONFIG_DFU_TFTP.
>
> Fixes: 3149e524fc1e ("common: update: add a generic interface for FIT
>        image")
> Signed-off-by: AKASHI Takahiro <[hidden email]>

Reviewed-by: Heinrich Schuchardt <[hidden email]>

> ---
>  drivers/dfu/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index b7427fc4f0d6..121dc54f5463 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -20,9 +20,8 @@ config DFU_WRITE_ALT
>
>  config DFU_TFTP
>   bool "DFU via TFTP"
> - select DFU_WRITE_ALT
> - select DFU_OVER_TFTP
>   select UPDATE_COMMON
> + select DFU_OVER_TFTP
>   help
>    This option allows performing update of DFU-managed medium with data
>    sent via TFTP boot.
>