[PATCH] cmd: disk: Remove fit_print_contents API

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] cmd: disk: Remove fit_print_contents API

Ravik Hasija
fit_print_contents prints similar fit information as printed in bootm stages.
Removing this API reduces redundancy & provides improvement in boottime.

Signed-off-by: Ravik Hasija <[hidden email]>
---

 cmd/disk.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cmd/disk.c b/cmd/disk.c
index 8060e753eb..0bc3808dfe 100644
--- a/cmd/disk.c
+++ b/cmd/disk.c
@@ -120,7 +120,6 @@ int common_diskboot(struct cmd_tbl *cmdtp, const char *intf, int argc,
  return 1;
  }
  bootstage_mark(BOOTSTAGE_ID_IDE_FIT_READ_OK);
- fit_print_contents(fit_hdr);
  }
 #endif
 
--
2.17.1

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cmd: disk: Remove fit_print_contents API

Simon Glass-3
On Fri, 8 Jan 2021 at 10:56, Ravik Hasija <[hidden email]> wrote:
>
> fit_print_contents prints similar fit information as printed in bootm stages.
> Removing this API reduces redundancy & provides improvement in boottime.
>
> Signed-off-by: Ravik Hasija <[hidden email]>
> ---
>
>  cmd/disk.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Simon Glass <[hidden email]>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] cmd: disk: Remove fit_print_contents API

Tom Rini-4
In reply to this post by Ravik Hasija
On Fri, Jan 08, 2021 at 09:55:58AM -0800, Ravik Hasija wrote:

> fit_print_contents prints similar fit information as printed in bootm stages.
> Removing this API reduces redundancy & provides improvement in boottime.
>
> Signed-off-by: Ravik Hasija <[hidden email]>
> Reviewed-by: Simon Glass <[hidden email]>

Applied to u-boot/master, thanks!

--
Tom

signature.asc (673 bytes) Download Attachment