[PATCH] Makefile: fix annoying sunxi hack message

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Makefile: fix annoying sunxi hack message

Frank Wunderlich-4
From: Frank Wunderlich <[hidden email]>

every compilation shows this error

 Hack for sunxi which doesn't have a proper binman definition for
 64-bit boards

not only for sunxi-boards/arm64

fix this by changing to real comments

Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
Signed-off-by: Frank Wunderlich <[hidden email]>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 4483a9bc8a..75c2987405 100644
--- a/Makefile
+++ b/Makefile
@@ -1024,8 +1024,8 @@ PHONY += inputs
 inputs: $(INPUTS-y)
 
 all: .binman_stamp inputs
- # Hack for sunxi which doesn't have a proper binman definition for
- # 64-bit boards
+# Hack for sunxi which doesn't have a proper binman definition for
+# 64-bit boards
 ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
 ifeq ($(CONFIG_BINMAN),y)
  $(call if_changed,binman)
--
2.25.1

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Makefile: fix annoying sunxi hack message

Tom Rini-4
On Tue, Aug 11, 2020 at 05:19:54PM +0200, Frank Wunderlich wrote:

> From: Frank Wunderlich <[hidden email]>
>
> every compilation shows this error
>
>  Hack for sunxi which doesn't have a proper binman definition for
>  64-bit boards
>
> not only for sunxi-boards/arm64
>
> fix this by changing to real comments
>
> Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
> Signed-off-by: Frank Wunderlich <[hidden email]>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 4483a9bc8a..75c2987405 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1024,8 +1024,8 @@ PHONY += inputs
>  inputs: $(INPUTS-y)
>  
>  all: .binman_stamp inputs
> - # Hack for sunxi which doesn't have a proper binman definition for
> - # 64-bit boards
> +# Hack for sunxi which doesn't have a proper binman definition for
> +# 64-bit boards
>  ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
>  ifeq ($(CONFIG_BINMAN),y)
>   $(call if_changed,binman)
Um, what environment is this failing on?  Thanks!

--
Tom

signature.asc (673 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Aw: Re: [PATCH] Makefile: fix annoying sunxi hack message

Frank Wunderlich-2
Hi

> Gesendet: Dienstag, 11. August 2020 um 17:32 Uhr
> Von: "Tom Rini" <[hidden email]>
> Um, what environment is this failing on?  Thanks!

i get this when compiling for bananapi-r2 (mt7623, armhf).

i guessed it is designed as comment, or should these printed for the sunxi?

build does not fail, but the "message" is printed and imho this was not intended ;)

regards Frank
Reply | Threaded
Open this post in threaded view
|

Aw: Re: [PATCH] Makefile: fix annoying sunxi hack message

Frank Wunderlich-2
In reply to this post by Tom Rini-4
> Gesendet: Dienstag, 11. August 2020 um 17:32 Uhr
> Von: "Tom Rini" <[hidden email]>

> Um, what environment is this failing on?  Thanks!

sorry forgot data about host where i compile it...i guess this is more interesting ;)

$ cat /etc/issue
Ubuntu 20.04.1 LTS \n \l
$ uname -a
Linux frank-G5-U20 5.4.52-custom #1 SMP Thu Jul 16 19:16:51 CEST 2020 x86_64 x86_64 x86_64 GNU/Linux
$ make -v
GNU Make 4.2.1
$ arm-linux-gnueabihf-gcc -v
Using built-in specs.
COLLECT_GCC=arm-linux-gnueabihf-gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc-cross/arm-linux-gnueabihf/8/lto-wrapper
Target: arm-linux-gnueabihf
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 8.4.0-3ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-8/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-8 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libitm --disable-libquadmath --disable-libquadmath-support --enable-plugin --enable-default-pie --with-system-zlib --without-target-system-zlib --enable-multiarch --enable-multilib --disable-sjlj-exceptions --with-arch=armv7-a --with-fpu=vfpv3-d16 --with-float=hard --with-mode=thumb --disable-werror --enable-multilib --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=arm-linux-gnueabihf --program-prefix=arm-linux-gnueabihf- --includedir=/usr/arm-linux-gnueabihf/include
Thread model: posix
gcc version 8.4.0 (Ubuntu/Linaro 8.4.0-3ubuntu1)

my config: https://github.com/frank-w/u-boot/blob/2020-10-bpi/configs/mt7623n_bpir2_defconfig
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Makefile: fix annoying sunxi hack message

Michal Simek-4
In reply to this post by Tom Rini-4
út 11. 8. 2020 v 17:33 odesílatel Tom Rini <[hidden email]> napsal:

>
> On Tue, Aug 11, 2020 at 05:19:54PM +0200, Frank Wunderlich wrote:
>
> > From: Frank Wunderlich <[hidden email]>
> >
> > every compilation shows this error
> >
> >  Hack for sunxi which doesn't have a proper binman definition for
> >  64-bit boards
> >
> > not only for sunxi-boards/arm64
> >
> > fix this by changing to real comments
> >
> > Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
> > Signed-off-by: Frank Wunderlich <[hidden email]>
> > ---
> >  Makefile | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 4483a9bc8a..75c2987405 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1024,8 +1024,8 @@ PHONY += inputs
> >  inputs: $(INPUTS-y)
> >
> >  all: .binman_stamp inputs
> > -     # Hack for sunxi which doesn't have a proper binman definition for
> > -     # 64-bit boards
> > +# Hack for sunxi which doesn't have a proper binman definition for
> > +# 64-bit boards
> >  ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
> >  ifeq ($(CONFIG_BINMAN),y)
> >       $(call if_changed,binman)
>
> Um, what environment is this failing on?  Thanks!

I also see this message when I build stuff for zynqmp.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Makefile: fix annoying sunxi hack message

Tom Rini-4
On Wed, Aug 12, 2020 at 09:59:15AM +0200, Michal Simek wrote:

> út 11. 8. 2020 v 17:33 odesílatel Tom Rini <[hidden email]> napsal:
> >
> > On Tue, Aug 11, 2020 at 05:19:54PM +0200, Frank Wunderlich wrote:
> >
> > > From: Frank Wunderlich <[hidden email]>
> > >
> > > every compilation shows this error
> > >
> > >  Hack for sunxi which doesn't have a proper binman definition for
> > >  64-bit boards
> > >
> > > not only for sunxi-boards/arm64
> > >
> > > fix this by changing to real comments
> > >
> > > Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
> > > Signed-off-by: Frank Wunderlich <[hidden email]>
> > > ---
> > >  Makefile | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index 4483a9bc8a..75c2987405 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -1024,8 +1024,8 @@ PHONY += inputs
> > >  inputs: $(INPUTS-y)
> > >
> > >  all: .binman_stamp inputs
> > > -     # Hack for sunxi which doesn't have a proper binman definition for
> > > -     # 64-bit boards
> > > +# Hack for sunxi which doesn't have a proper binman definition for
> > > +# 64-bit boards
> > >  ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
> > >  ifeq ($(CONFIG_BINMAN),y)
> > >       $(call if_changed,binman)
> >
> > Um, what environment is this failing on?  Thanks!
>
> I also see this message when I build stuff for zynqmp.
Interesting, are you also on make 4.2 ?

--
Tom

signature.asc (673 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Makefile: fix annoying sunxi hack message

Michal Simek-4


On 12. 08. 20 13:41, Tom Rini wrote:

> On Wed, Aug 12, 2020 at 09:59:15AM +0200, Michal Simek wrote:
>> út 11. 8. 2020 v 17:33 odesílatel Tom Rini <[hidden email]> napsal:
>>>
>>> On Tue, Aug 11, 2020 at 05:19:54PM +0200, Frank Wunderlich wrote:
>>>
>>>> From: Frank Wunderlich <[hidden email]>
>>>>
>>>> every compilation shows this error
>>>>
>>>>  Hack for sunxi which doesn't have a proper binman definition for
>>>>  64-bit boards
>>>>
>>>> not only for sunxi-boards/arm64
>>>>
>>>> fix this by changing to real comments
>>>>
>>>> Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
>>>> Signed-off-by: Frank Wunderlich <[hidden email]>
>>>> ---
>>>>  Makefile | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Makefile b/Makefile
>>>> index 4483a9bc8a..75c2987405 100644
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -1024,8 +1024,8 @@ PHONY += inputs
>>>>  inputs: $(INPUTS-y)
>>>>
>>>>  all: .binman_stamp inputs
>>>> -     # Hack for sunxi which doesn't have a proper binman definition for
>>>> -     # 64-bit boards
>>>> +# Hack for sunxi which doesn't have a proper binman definition for
>>>> +# 64-bit boards
>>>>  ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
>>>>  ifeq ($(CONFIG_BINMAN),y)
>>>>       $(call if_changed,binman)
>>>
>>> Um, what environment is this failing on?  Thanks!
>>
>> I also see this message when I build stuff for zynqmp.
>
> Interesting, are you also on make 4.2 ?
I am on 4.1.

Michal


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs



signature.asc (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Makefile: fix annoying sunxi hack message

Tom Rini-4
On Wed, Aug 12, 2020 at 01:48:33PM +0200, Michal Simek wrote:

>
>
> On 12. 08. 20 13:41, Tom Rini wrote:
> > On Wed, Aug 12, 2020 at 09:59:15AM +0200, Michal Simek wrote:
> >> út 11. 8. 2020 v 17:33 odesílatel Tom Rini <[hidden email]> napsal:
> >>>
> >>> On Tue, Aug 11, 2020 at 05:19:54PM +0200, Frank Wunderlich wrote:
> >>>
> >>>> From: Frank Wunderlich <[hidden email]>
> >>>>
> >>>> every compilation shows this error
> >>>>
> >>>>  Hack for sunxi which doesn't have a proper binman definition for
> >>>>  64-bit boards
> >>>>
> >>>> not only for sunxi-boards/arm64
> >>>>
> >>>> fix this by changing to real comments
> >>>>
> >>>> Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
> >>>> Signed-off-by: Frank Wunderlich <[hidden email]>
> >>>> ---
> >>>>  Makefile | 4 ++--
> >>>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/Makefile b/Makefile
> >>>> index 4483a9bc8a..75c2987405 100644
> >>>> --- a/Makefile
> >>>> +++ b/Makefile
> >>>> @@ -1024,8 +1024,8 @@ PHONY += inputs
> >>>>  inputs: $(INPUTS-y)
> >>>>
> >>>>  all: .binman_stamp inputs
> >>>> -     # Hack for sunxi which doesn't have a proper binman definition for
> >>>> -     # 64-bit boards
> >>>> +# Hack for sunxi which doesn't have a proper binman definition for
> >>>> +# 64-bit boards
> >>>>  ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
> >>>>  ifeq ($(CONFIG_BINMAN),y)
> >>>>       $(call if_changed,binman)
> >>>
> >>> Um, what environment is this failing on?  Thanks!
> >>
> >> I also see this message when I build stuff for zynqmp.
> >
> > Interesting, are you also on make 4.2 ?
>
> I am on 4.1.
Ugh.  I'll apply the patch shortly as clearly we need it.  But I don't
see why it's failing in some places and not others, which is worrying.

--
Tom

signature.asc (673 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Makefile: fix annoying sunxi hack message

Tom Rini-4
In reply to this post by Frank Wunderlich-4
On Tue, Aug 11, 2020 at 05:19:54PM +0200, Frank Wunderlich wrote:

> From: Frank Wunderlich <[hidden email]>
>
> every compilation shows this error
>
>  Hack for sunxi which doesn't have a proper binman definition for
>  64-bit boards
>
> not only for sunxi-boards/arm64
>
> fix this by changing to real comments
>
> Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
> Signed-off-by: Frank Wunderlich <[hidden email]>
Applied to u-boot/master, thanks!

--
Tom

signature.asc (673 bytes) Download Attachment