[PATCH 3/4] board: keymile: common: fix pnvramaddr and varaddr address calculation

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 3/4] board: keymile: common: fix pnvramaddr and varaddr address calculation

Aleksandar Gerasimovski
Take into account SDRAM_BASE address when calculating pnvramaddr and
varaddr offsets.
Up to now Keymile designs had SDRAM_BASE equal to zero and the offsets
where calculated correctly, this fix is for the upcoming designs that
have SDRAM_BASE different then zero.

Signed-off-by: Aleksandar Gerasimovski <[hidden email]>
---
 board/keymile/common/common.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
index df507e2..e3e9c4a 100644
--- a/board/keymile/common/common.c
+++ b/board/keymile/common/common.c
@@ -49,8 +49,8 @@ int set_km_env(void)
  char *p;
  unsigned long rootfssize = 0;
 
- pnvramaddr = gd->ram_size - CONFIG_KM_RESERVED_PRAM - CONFIG_KM_PHRAM
- - CONFIG_KM_PNVRAM;
+ pnvramaddr = CONFIG_SYS_SDRAM_BASE + gd->ram_size -
+ CONFIG_KM_RESERVED_PRAM - CONFIG_KM_PHRAM - CONFIG_KM_PNVRAM;
  sprintf((char *)buf, "0x%x", pnvramaddr);
  env_set("pnvramaddr", (char *)buf);
 
@@ -63,7 +63,8 @@ int set_km_env(void)
  sprintf((char *)buf, "0x%x", pram);
  env_set("pram", (char *)buf);
 
- varaddr = gd->ram_size - CONFIG_KM_RESERVED_PRAM - CONFIG_KM_PHRAM;
+ varaddr = CONFIG_SYS_SDRAM_BASE + gd->ram_size -
+ CONFIG_KM_RESERVED_PRAM - CONFIG_KM_PHRAM;
  sprintf((char *)buf, "0x%x", varaddr);
  env_set("varaddr", (char *)buf);
 
--
1.8.3.1
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH 3/4] board: keymile: common: fix pnvramaddr and varaddr address calculation

Priyanka Jain (OSS)


>-----Original Message-----
>From: U-Boot <[hidden email]> On Behalf Of Aleksandar
>Gerasimovski
>Sent: Wednesday, January 13, 2021 9:51 PM
>To: [hidden email]
>Cc: Valentin Longchamp <[hidden email]>; Holger
>Brunck <[hidden email]>; Rainer Boschung
><[hidden email]>; Matteo Ghidoni
><[hidden email]>
>Subject: [PATCH 3/4] board: keymile: common: fix pnvramaddr and varaddr
>address calculation
>
Please trim subject line to 60 characters
>Take into account SDRAM_BASE address when calculating pnvramaddr and
>varaddr offsets.
>Up to now Keymile designs had SDRAM_BASE equal to zero and the offsets where
>calculated correctly, this fix is for the upcoming designs that have SDRAM_BASE
>different then zero.
>
>Signed-off-by: Aleksandar Gerasimovski <aleksandar.gerasimovski@hitachi-
>powergrids.com>
<snip>

Regards
Priyanka