[PATCH 1/1] tools: efivar.py without arguments

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] tools: efivar.py without arguments

Heinrich Schuchardt
When tools: efivar.py is called without arguments an error occurs:

Traceback (most recent call last):
  File "tools/efivar.py", line 380, in <module>
    main()
  File "tools/efivar.py", line 360, in main
    args.func(args)
AttributeError: 'Namespace' object has no attribute 'func'

Show the online help if the arguments do not specify a function.

Signed-off-by: Heinrich Schuchardt <[hidden email]>
---
 tools/efivar.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/efivar.py b/tools/efivar.py
index ebfcab2f0a..c40a0fa6c7 100755
--- a/tools/efivar.py
+++ b/tools/efivar.py
@@ -357,7 +357,10 @@ def main():
     signp.set_defaults(func=cmd_sign)

     args = ap.parse_args()
-    args.func(args)
+    if hasattr(args, "func"):
+        args.func(args)
+    else:
+        ap.print_help()

 def group(a, *ns):
     for n in ns:
--
2.29.2

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] tools: efivar.py without arguments

Paulo Alcantara
Heinrich Schuchardt <[hidden email]> writes:

> When tools: efivar.py is called without arguments an error occurs:
>
> Traceback (most recent call last):
>   File "tools/efivar.py", line 380, in <module>
>     main()
>   File "tools/efivar.py", line 360, in main
>     args.func(args)
> AttributeError: 'Namespace' object has no attribute 'func'
>
> Show the online help if the arguments do not specify a function.
>
> Signed-off-by: Heinrich Schuchardt <[hidden email]>
> ---
>  tools/efivar.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Paulo Alcantara (SUSE) <[hidden email]>