[PATCH 1/1] tools: efivar.py unused variable

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] tools: efivar.py unused variable

Heinrich Schuchardt
Unused variables should be called '_'.

Signed-off-by: Heinrich Schuchardt <[hidden email]>
---
 tools/efivar.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/efivar.py b/tools/efivar.py
index 29eb90a235..67729fa850 100755
--- a/tools/efivar.py
+++ b/tools/efivar.py
@@ -292,7 +292,7 @@ def pkcs7_sign(cert, key, buf):

 # UEFI 2.8 Errata B "8.2.2 Using the EFI_VARIABLE_AUTHENTICATION_2 descriptor"
 def cmd_sign(args):
-    guid, name, attrs, data, size = parse_args(args)
+    guid, name, attrs, data, _ = parse_args(args)
     attrs |= EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS
     efi = EfiStruct()

--
2.29.2

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] tools: efivar.py unused variable

Paulo Alcantara
Heinrich Schuchardt <[hidden email]> writes:

> Unused variables should be called '_'.
>
> Signed-off-by: Heinrich Schuchardt <[hidden email]>
> ---
>  tools/efivar.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Paulo Alcantara (SUSE) <[hidden email]>