[PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Heinrich Schuchardt
Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
for espresso7420_defconfig.

Signed-off-by: Heinrich Schuchardt <[hidden email]>
---
 include/configs/espresso7420.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
index 5aeb009f03..2495db93f8 100644
--- a/include/configs/espresso7420.h
+++ b/include/configs/espresso7420.h
@@ -18,9 +18,6 @@
 #define CONFIG_SPL_STACK CONFIG_IRAM_END
 #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END

-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
-
 /* DRAM Memory Banks */
 #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */

--
2.28.0

Reply | Threaded
Open this post in threaded view
|

Fwd: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Heinrich Schuchardt

Hello Thomas,

I tried to send an U-Boot patch to Thomas Abraham
<[hidden email]>. But the email address [hidden email]
does not exist anymore.

I assume that you are the same person.

What shall happen with board/samsung/espresso7420/MAINTAINERS?

Best regards

Heinrich

-------- Forwarded Message --------
Subject: [PATCH 1/1] espresso7420: remove unused symbol
CONFIG_DEFAULT_CONSOLE
Date: Sat,  5 Sep 2020 12:02:10 +0200
From: Heinrich Schuchardt <[hidden email]>
To: Thomas Abraham <[hidden email]>
CC: [hidden email], Heinrich Schuchardt <[hidden email]>

Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
for espresso7420_defconfig.

Signed-off-by: Heinrich Schuchardt <[hidden email]>
---
 include/configs/espresso7420.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
index 5aeb009f03..2495db93f8 100644
--- a/include/configs/espresso7420.h
+++ b/include/configs/espresso7420.h
@@ -18,9 +18,6 @@
 #define CONFIG_SPL_STACK CONFIG_IRAM_END
 #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END

-/* select serial console configuration */
-#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
-
 /* DRAM Memory Banks */
 #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */

--
2.28.0

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Andre Heider
In reply to this post by Heinrich Schuchardt
On 05/09/2020 12:02, Heinrich Schuchardt wrote:
> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
> for espresso7420_defconfig.
>
> Signed-off-by: Heinrich Schuchardt <[hidden email]>

I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
there're quite some boards with it set but unused:
include/configs/arndale.h
include/configs/peach-pi.h
include/configs/peach-pit.h
include/configs/smdk5250.h
include/configs/smdkv310.h
include/configs/snow.h
include/configs/spring.h

This one even defines it twice (looks like a rebase gone wrong), still
unused:
include/configs/smdk5420.h
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"

Last but not least:
include/configs/origen.h
#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
"console=ttySAC2,115200n8\0"

Btw, *all* hits for CONFIG_DEFAULT_CONSOLE are ttySAC*.

Regards,
Andre

> ---
>   include/configs/espresso7420.h | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
> index 5aeb009f03..2495db93f8 100644
> --- a/include/configs/espresso7420.h
> +++ b/include/configs/espresso7420.h
> @@ -18,9 +18,6 @@
>   #define CONFIG_SPL_STACK CONFIG_IRAM_END
>   #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END
>
> -/* select serial console configuration */
> -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
> -
>   /* DRAM Memory Banks */
>   #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */
>
> --
> 2.28.0
>

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Heinrich Schuchardt
On 9/6/20 9:00 PM, Andre Heider wrote:
> On 05/09/2020 12:02, Heinrich Schuchardt wrote:
>> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not
>> used
>> for espresso7420_defconfig.
>>
>> Signed-off-by: Heinrich Schuchardt <[hidden email]>
>
> I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
> there're quite some boards with it set but unused:

Thanks for reviewing. As the boards have different maintainers we should
treat them in separate patches.

Best regards

Heinrich

> include/configs/arndale.h
> include/configs/peach-pi.h
> include/configs/peach-pit.h
> include/configs/smdk5250.h
> include/configs/smdkv310.h
> include/configs/snow.h
> include/configs/spring.h
>
> This one even defines it twice (looks like a rebase gone wrong), still
> unused:
> include/configs/smdk5420.h
> #define CONFIG_DEFAULT_CONSOLE    "console=ttySAC1,115200n8\0"
> #define CONFIG_DEFAULT_CONSOLE        "console=ttySAC1,115200n8\0"
>
> Last but not least:
> include/configs/origen.h
> #define CONFIG_DEFAULT_CONSOLE        "console=ttySAC1,115200n8\0"
> "console=ttySAC2,115200n8\0"
>
> Btw, *all* hits for CONFIG_DEFAULT_CONSOLE are ttySAC*.
>
> Regards,
> Andre
>
>> ---
>>   include/configs/espresso7420.h | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/include/configs/espresso7420.h
>> b/include/configs/espresso7420.h
>> index 5aeb009f03..2495db93f8 100644
>> --- a/include/configs/espresso7420.h
>> +++ b/include/configs/espresso7420.h
>> @@ -18,9 +18,6 @@
>>   #define CONFIG_SPL_STACK        CONFIG_IRAM_END
>>   #define CONFIG_SYS_INIT_SP_ADDR        CONFIG_IRAM_END
>>
>> -/* select serial console configuration */
>> -#define CONFIG_DEFAULT_CONSOLE    "console=ttySAC1,115200n8\0"
>> -
>>   /* DRAM Memory Banks */
>>   #define SDRAM_BANK_SIZE        (256UL << 20UL)    /* 256 MB */
>>
>> --
>> 2.28.0
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: Fwd: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Thomas Abraham-5
In reply to this post by Heinrich Schuchardt
Sorry, Heinrich. Unfortunately, we are not the same person.

Best regards,

Tom Abraham

On 9/5/20 6:55 AM, Heinrich Schuchardt wrote:

> Hello Thomas,
>
> I tried to send an U-Boot patch to Thomas Abraham
> <[hidden email]>. But the email address [hidden email]
> does not exist anymore.
>
> I assume that you are the same person.
>
> What shall happen with board/samsung/espresso7420/MAINTAINERS?
>
> Best regards
>
> Heinrich
>
> -------- Forwarded Message --------
> Subject: [PATCH 1/1] espresso7420: remove unused symbol
> CONFIG_DEFAULT_CONSOLE
> Date: Sat,  5 Sep 2020 12:02:10 +0200
> From: Heinrich Schuchardt <[hidden email]>
> To: Thomas Abraham <[hidden email]>
> CC: [hidden email], Heinrich Schuchardt <[hidden email]>
>
> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
> for espresso7420_defconfig.
>
> Signed-off-by: Heinrich Schuchardt <[hidden email]>
> ---
>  include/configs/espresso7420.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
> index 5aeb009f03..2495db93f8 100644
> --- a/include/configs/espresso7420.h
> +++ b/include/configs/espresso7420.h
> @@ -18,9 +18,6 @@
>  #define CONFIG_SPL_STACK CONFIG_IRAM_END
>  #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END
>
> -/* select serial console configuration */
> -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0"
> -
>  /* DRAM Memory Banks */
>  #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */
>
> --
> 2.28.0
>

pEpkey.asc (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Minkyu Kang
In reply to this post by Heinrich Schuchardt
Dear Heinrich Schuchardt,

On 07/09/2020 04:33, Heinrich Schuchardt wrote:

> On 9/6/20 9:00 PM, Andre Heider wrote:
>> On 05/09/2020 12:02, Heinrich Schuchardt wrote:
>>> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not
>>> used
>>> for espresso7420_defconfig.
>>>
>>> Signed-off-by: Heinrich Schuchardt <[hidden email]>
>>
>> I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
>> there're quite some boards with it set but unused:
>
> Thanks for reviewing. As the boards have different maintainers we should
> treat them in separate patches.
>

Because those are all Samsung boards, I can approve them.
If you want please send changes to patch-set or single patch with adding maintainers as a CC.

thomas.ab seems to exited from company.
I will find new maintainer soon.

Thanks,
Minkyu Kang.

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE

Minkyu Kang-2
Dear Heinrich Schuchardt,

On Mon, 7 Sep 2020 at 14:13, Minkyu Kang <[hidden email]> wrote:

> Dear Heinrich Schuchardt,
>
> On 07/09/2020 04:33, Heinrich Schuchardt wrote:
> > On 9/6/20 9:00 PM, Andre Heider wrote:
> >> On 05/09/2020 12:02, Heinrich Schuchardt wrote:
> >>> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not
> >>> used
> >>> for espresso7420_defconfig.
> >>>
> >>> Signed-off-by: Heinrich Schuchardt <[hidden email]>
> >>
> >> I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict
> >> there're quite some boards with it set but unused:
> >
> > Thanks for reviewing. As the boards have different maintainers we should
> > treat them in separate patches.
> >
>
> Because those are all Samsung boards, I can approve them.
> If you want please send changes to patch-set or single patch with adding
> maintainers as a CC.
>
> thomas.ab seems to exited from company.
> I will find new maintainer soon.
>
> Thanks,
> Minkyu Kang.
>
>
Your patch was replaced by Heider's patch.
I added your signed-off at that patch.