[PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h

Heinrich Schuchardt
Functions that are used in multiple C modules should be defined in an
include.

Signed-off-by: Heinrich Schuchardt <[hidden email]>
---
 include/bootm.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/bootm.h b/include/bootm.h
index 0350c349f3..a812a6bf24 100644
--- a/include/bootm.h
+++ b/include/bootm.h
@@ -75,4 +75,14 @@ void board_quiesce_devices(void);
  */
 void switch_to_non_secure_mode(void);

+/**
+ * arch_preboot_os() - arch specific configuration before booting
+ */
+void arch_preboot_os(void);
+
+/**
+ * board_preboot_os() - board specific configuration before booting
+ */
+void board_preboot_os(void);
+
 #endif
--
2.28.0

Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h

Heinrich Schuchardt
Functions that are used in multiple C modules should be defined in an
include.

Signed-off-by: Heinrich Schuchardt <[hidden email]>
---
 include/bootm.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/bootm.h b/include/bootm.h
index 0350c349f3..a812a6bf24 100644
--- a/include/bootm.h
+++ b/include/bootm.h
@@ -75,4 +75,14 @@ void board_quiesce_devices(void);
  */
 void switch_to_non_secure_mode(void);

+/**
+ * arch_preboot_os() - arch specific configuration before booting
+ */
+void arch_preboot_os(void);
+
+/**
+ * board_preboot_os() - board specific configuration before booting
+ */
+void board_preboot_os(void);
+
 #endif
--
2.28.0

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h

Michael Walle-2
Am 2020-09-15 01:58, schrieb Heinrich Schuchardt:
> Functions that are used in multiple C modules should be defined in an
> include.
>
> Signed-off-by: Heinrich Schuchardt <[hidden email]>

Reviewed-by: Michael Walle <[hidden email]>

I've noticed that the boards which use arch_preboot_os() (?!) or
board_preboot_os() doesn't include this header, though.

-michael
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h

Heinrich Schuchardt
On 15.09.20 09:38, Michael Walle wrote:

> Am 2020-09-15 01:58, schrieb Heinrich Schuchardt:
>> Functions that are used in multiple C modules should be defined in an
>> include.
>>
>> Signed-off-by: Heinrich Schuchardt <[hidden email]>
>
> Reviewed-by: Michael Walle <[hidden email]>
>
> I've noticed that the boards which use arch_preboot_os() (?!) or
> board_preboot_os() doesn't include this header, though.

Yes, this will require further patches.

Best regards

Heinrich
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h

Tom Rini-4
In reply to this post by Heinrich Schuchardt
On Tue, Sep 15, 2020 at 01:58:11AM +0200, Heinrich Schuchardt wrote:

> Functions that are used in multiple C modules should be defined in an
> include.
>
> Signed-off-by: Heinrich Schuchardt <[hidden email]>
> Reviewed-by: Michael Walle <[hidden email]>

Applied to u-boot/master, thanks!

--
Tom

signature.asc (673 bytes) Download Attachment