My 3 patches

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

My 3 patches

luo.jinhua
Hi.

Here is my 3 patches.

sbc2410x.patch is for the new board -- SBC-2410X. I write this new
hardware-specific configurations refer to smdk2410 configurations in U-Boot.
File list:
 MAKEALL
 Makefile
 board/sbc2410x/Makefile
 board/sbc2410x/config.mk
 board/sbc2410x/flash.c
 board/sbc2410x/lowlevel_init.S
 board/sbc2410x/sbc2410x.c
 board/sbc2410x/u-boot.lds
 cpu/arm920t/s3c24x0/interrupts.c
 include/configs/sbc2410x.h
This patch adds a new configuration option -- CONFIG_SBC2410X.

cmdline_editing.patch implements cmdline-editing extension of readline. I pick
codes heavily borrowed from vivi bootloader and integrate them into U-Boot.
File list:
 common/main.c
This patch adds a new configuration option -- CONFIG_CMDLINE_EDITING.

nand_for_sbc2410x.patch adds nand support for SBC-2410X board.  It do that by
taking nand controller specific codes (from VCMA9 board) in place.
File list:
 common/cmd_nand.c
 include/linux/mtd/nand.h
 include/linux/mtd/nand_ids.h

more detail please review:
http://sourceforge.net/mailarchive/forum.php?thread_id=8089177&forum_id=12898

CHANGELOG item:
* Add support for friendly-arm SBC-2410X board
  Patch by JinHua Luo, 1 Sep 2005
* Add to readline cmdline-editing extension
  Patch by JinHua Luo, 1 Sep 2005
* Add nand support for SBC-2410X
  Patch by JinHua Luo, 1 Sep 2005

CREDIT item (if proper):
N: JinHua Luo
E: [hidden email] [hidden email]
D: Support for friendly-arm SBC-2410X board
D: Add to readline cmdline-editing extension
D: Add nand support for SBC-2410X
W: www.gd-linux.com

Best regards,
 
luo.jinhua

--
JinHua Luo, GuangDong Linux Center, <[hidden email]>


cmdline_editing.patch.gz (3K) Download Attachment
sbc2410x.patch.gz (12K) Download Attachment
nand_for_sbc2410x.patch.gz (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: My 3 patches

luo.jinhua
Hi, Wolfgang.

How about my 3 patches? I'm looking forward to your reply. Thanks.

By the way, SBC-2410X board is made by friendly-arm, a chinese corporation.
Here is a manual webpage for SBC-2410X (in Chinese):
http://www.arm9.net/matrix-v.asp

Recently, I am working on making U-Boot boot from nand on SBC-2410X board. Do
you think it is meaningful? In my opinion, nand flash has at least advantages
below:
1. nand flash is cheaper than nor flash.
2. nand flash is bigger than nor flash in size.
We can boot from nand flash, meanwhile it serves as data rom too. Nor flash
seems redundancy on the board.

Of course, nor flash is popular yet. No wonder that U-Boot considers nor flash
as boot rom by default. But, why SAMSUNG's S3C2410X owns builtin "boot from
nand" function? It hints.

"Recently, a NOR flash memory gets high in price while an SDRAM and a NAND
flash memory get moderate,
motivating some users to execute the boot code on a NAND flash and execute the
main code on an SDRAM.

S3C2410X boot code can be executed on an external NAND flash memory. In order
to support NAND flash boot
loader, the S3C2410X is equipped with an internal SRAM buffer called
‘Steppingstone’. When booting, the first 4
KBytes of the NAND flash memory will be loaded into Steppingstone and the boot
code loaded into
Steppingstone will be executed."

--quoted from S3C2410X's datasheet.

Correspondingly, YAFFS, a NAND-flash friendly filing system, will be a good
choice to be added into U-Boot.
More detail:
http://www.aleph1.co.uk/armlinux/projects/

Best regards,
 
luo.jinhua

----------
JinHua Luo, GuangDong Linux Center, <[hidden email]>



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
U-Boot-Users mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Re: My 3 patches

Wolfgang Denk
In message <[hidden email]> you wrote:
>
> How about my 3 patches? I'm looking forward to your reply. Thanks.

They are sitting in my queue waiting to be  reviewed  and  eventually
applied or rejected. Please be patient.

> Here is a manual webpage for SBC-2410X (in Chinese):
> http://www.arm9.net/matrix-v.asp

Is there an English manual, too?

> Recently, I am working on making U-Boot boot from nand on SBC-2410X board. Do
> you think it is meaningful? In my opinion, nand flash has at least advantages

This can be an issue if you have really high volumes of  your  boards
and   try   to  minimize  the  production  cost  at  the  expense  of
reliability.

> ¡®Steppingstone¡¯. When booting, the first 4
> KBytes of the NAND flash memory will be loaded into Steppingstone and the boot
> code loaded into
> Steppingstone will be executed."

Here you see the problem: you will need a separate first stage loader
to do all the low level initializations and then load U-Boot  to  RAM
like  it  has  been  implemented  on  some  other systems before. The
probelm is that all  comfort  you  have  witrh  U-Boot  during  board
bringup and U-Bootporting gets lost this way.

> Correspondingly, YAFFS, a NAND-flash friendly filing system, will be a good
> choice to be added into U-Boot.

Feel free to submit patches.

Best regards,

Wolfgang Denk

--
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [hidden email]
We have found all life forms in the galaxy are  capable  of  superior
development.
        -- Kirk, "The Gamesters of Triskelion", stardate 3211.7


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
U-Boot-Users mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: My 3 patches

Bryan Wu
In reply to this post by luo.jinhua
Hi:

I applied your patch my U-Boot. But I found one bug in this patch
in cread_line() function, you should return the number of read characters.
You return the "rc" at the end of the function, but rc always equals 0.
The u-boot command will NOT be executed.

I modified the to return (eol_num). It is ok.

You can check it.

Bryan Wu from China.

----- Original Message -----
From: "luo.jinhua" <[hidden email]>
To: "u-boot-users" <[hidden email]>
Sent: Friday, September 02, 2005 10:02 AM
Subject: [U-Boot-Users] My 3 patches


> Hi.
>
> Here is my 3 patches.
>
> sbc2410x.patch is for the new board -- SBC-2410X. I write this new
> hardware-specific configurations refer to smdk2410 configurations in U-Boot.
> File list:
> MAKEALL
> Makefile
> board/sbc2410x/Makefile
> board/sbc2410x/config.mk
> board/sbc2410x/flash.c
> board/sbc2410x/lowlevel_init.S
> board/sbc2410x/sbc2410x.c
> board/sbc2410x/u-boot.lds
> cpu/arm920t/s3c24x0/interrupts.c
> include/configs/sbc2410x.h
> This patch adds a new configuration option -- CONFIG_SBC2410X.
>
> cmdline_editing.patch implements cmdline-editing extension of readline. I pick
> codes heavily borrowed from vivi bootloader and integrate them into U-Boot.
> File list:
> common/main.c
> This patch adds a new configuration option -- CONFIG_CMDLINE_EDITING.
>
> nand_for_sbc2410x.patch adds nand support for SBC-2410X board.  It do that by
> taking nand controller specific codes (from VCMA9 board) in place.
> File list:
> common/cmd_nand.c
> include/linux/mtd/nand.h
> include/linux/mtd/nand_ids.h
>
> more detail please review:
> http://sourceforge.net/mailarchive/forum.php?thread_id=8089177&forum_id=12898
>
> CHANGELOG item:
> * Add support for friendly-arm SBC-2410X board
>  Patch by JinHua Luo, 1 Sep 2005
> * Add to readline cmdline-editing extension
>  Patch by JinHua Luo, 1 Sep 2005
> * Add nand support for SBC-2410X
>  Patch by JinHua Luo, 1 Sep 2005
>
> CREDIT item (if proper):
> N: JinHua Luo
> E: [hidden email] [hidden email]
> D: Support for friendly-arm SBC-2410X board
> D: Add to readline cmdline-editing extension
> D: Add nand support for SBC-2410X
> W: www.gd-linux.com
>
> Best regards,
>
> luo.jinhua
>
> --
> JinHua Luo, GuangDong Linux Center, <[hidden email]>
>
>HS^甸��X��'��u�jg并贻z鳐����!jY^���+a����z�'�j���鳙�'����阻���y┹m绉店�v�0�v岗�Z�f��颌觑z绩�t�+f=#�'$�贽�ek(m����q玷��z哙z�'�j)���T标�ē�x%��T�-R谦�X�端(悍~��zw���i���l��q玷��z咤��l�X��)撸���n标�
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: My 3 patches

luo.jinhua
On Fri, 16 Sep 2005 18:36:09 +0800, Bryan Wu wrote

> Hi:
>
> I applied your patch my U-Boot. But I found one bug in this patch
> in cread_line() function, you should return the number of read characters.
> You return the "rc" at the end of the function, but rc always equals
> 0. The u-boot command will NOT be executed.
>
> I modified the to return (eol_num). It is ok.
>
> You can check it.
>
> Bryan Wu from China.
Thank you.

It is indeed a bug. However, while I always use CFG_HUSH_PARSER, the hush
engine ignores the "rc" retval and recalculates the console_buffer length,
which make me miss the bug.

Best regards,
 
luo.jinhua
----------
JinHua Luo, GuangDong Linux Center, <[hidden email]>



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
U-Boot-Users mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: My 3 patches

Wolfgang Denk
In reply to this post by luo.jinhua
Dear JinHua Luo,

in message <[hidden email]> you wrote:
>
> Here is my 3 patches.

Thanks a lot for your contribution.

> sbc2410x.patch is for the new board -- SBC-2410X. I write this new
> hardware-specific configurations refer to smdk2410 configurations in U-Boot.

Applied, thanks.

> cmdline_editing.patch implements cmdline-editing extension of readline. I pick
> codes heavily borrowed from vivi bootloader and integrate them into U-Boot.

Applied, thanks a lot!

> This patch adds a new configuration option -- CONFIG_CMDLINE_EDITING.

...which should have been documented in the README (I did this for
you).

> nand_for_sbc2410x.patch adds nand support for SBC-2410X board.  It do that by
> taking nand controller specific codes (from VCMA9 board) in place.
> File list:
>  common/cmd_nand.c
>  include/linux/mtd/nand.h
>  include/linux/mtd/nand_ids.h

I did not add this patch, though. I think you will have to  adapt  it
to  the  current  (new)  NAND code first. Can you please do this, and
then resubmit this part? Thanks!

Best regards,

Wolfgang Denk

--
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [hidden email]
The light at the end of the tunnel is usually a "No Exit" sign.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
U-Boot-Users mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Loading...