Habv4 on imx8m

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Habv4 on imx8m

Stefano Babic
Hi Peng, Fabio,

I accidental saw this code:

arch/arm/mach-imx/imx8m/soc.c:#if defined(CONFIG_IMX_HAB)

but then arch/arm/mach-imx/Kconfig  :

config IMX_HAB
         bool "Support i.MX HAB features"
         depends on ARCH_MX7 || ARCH_MX6 || ARCH_MX5

this does not match. As I understand from manual, Habv4 is the same as
in mx6. Should we simply enable HAB for imx8m, too ?

Regards,
Stefano

--
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [hidden email]
=====================================================================
Reply | Threaded
Open this post in threaded view
|

Re: Habv4 on imx8m

Fabio Estevam-2
Hi Stefano,

On Tue, Jan 12, 2021 at 12:03 PM Stefano Babic <[hidden email]> wrote:

>
> Hi Peng, Fabio,
>
> I accidental saw this code:
>
> arch/arm/mach-imx/imx8m/soc.c:#if defined(CONFIG_IMX_HAB)
>
> but then arch/arm/mach-imx/Kconfig  :
>
> config IMX_HAB
>          bool "Support i.MX HAB features"
>          depends on ARCH_MX7 || ARCH_MX6 || ARCH_MX5
>
> this does not match. As I understand from manual, Habv4 is the same as
> in mx6. Should we simply enable HAB for imx8m, too ?

You are right. This should be enabled for i.MX8M too.

The vendor U-Boot code does like this:

config IMX_HAB
bool "Support i.MX HAB features"
depends on ARCH_MX7 || ARCH_MX6 || ARCH_MX5 || ARCH_MX7ULP || ARCH_IMX8M

I can submit a patch adding mx7ulp and imx8m if you want.

Thanks
Reply | Threaded
Open this post in threaded view
|

Re: Habv4 on imx8m

Stefano Babic
On 12.01.21 16:21, Fabio Estevam wrote:

> Hi Stefano,
>
> On Tue, Jan 12, 2021 at 12:03 PM Stefano Babic <[hidden email]> wrote:
>>
>> Hi Peng, Fabio,
>>
>> I accidental saw this code:
>>
>> arch/arm/mach-imx/imx8m/soc.c:#if defined(CONFIG_IMX_HAB)
>>
>> but then arch/arm/mach-imx/Kconfig  :
>>
>> config IMX_HAB
>>          bool "Support i.MX HAB features"
>>          depends on ARCH_MX7 || ARCH_MX6 || ARCH_MX5
>>
>> this does not match. As I understand from manual, Habv4 is the same as
>> in mx6. Should we simply enable HAB for imx8m, too ?
>
> You are right. This should be enabled for i.MX8M too.
>
> The vendor U-Boot code does like this:
>
> config IMX_HAB
> bool "Support i.MX HAB features"
> depends on ARCH_MX7 || ARCH_MX6 || ARCH_MX5 || ARCH_MX7ULP || ARCH_IMX8M
>
> I can submit a patch adding mx7ulp and imx8m if you want.
>

Nice, thanks !

Stefano
> Thanks
>


--
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [hidden email]
=====================================================================